search

Flameish / Novel-Grabber

Novel-Grabber can download novels from pretty much any webnovel and lightnovel site.
MIT License
472 stars 62 forks source link

[BUG] Cant create PDF of large/long series #261

Open xx255q opened 3 years ago

xx255q commented 3 years ago

Describe the bug Both from Wuxiaworld, Overgeared and Martial God Asura. It will get to download finished, Writing PDF. a 0 KB PDF will show up but never get larger and in Novel Grabber does not get past the writing to PDF. I also tried a smaller series Genius Detective and after 20-30 minutes it was able to successfully complete the PDF.

Platform OS - Windows 10 20H2 Java - Latest

Logs Logs not working, only shows no setting or library file found

Additional context Had a questions

  1. When I changed the download path in favorites the picture for the series disappears
Flameish commented 3 years ago

Does it work with EPUB? You could also try running NG from the console, you might get errors that way.

The cover image is saved to that path. I'll see about moving the cover/ storing it differently.

xx255q commented 3 years ago

Well it did work with epub but the issue is komga, the software I use to read things like this, does not support epub, so this does not help me. Also, a 1 chapter novel update file for Overgeared was able to be created so far I know something under 800 chapters works but something at least as large as 1460 chapters (Overgeared) fails. In bin I found a test document called log but only with what I said before in it. Is there a way to start getting logs/fix it on my end or is this a bug you need to fix?

On Sun, Aug 1, 2021 at 7:08 AM Flameish @.***> wrote:

Does it work with EPUB? You could also try running NG from the console, you might get errors that way.

The cover image is saved to that path. I'll see about moving the cover/ storing it differently.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Flameish/Novel-Grabber/issues/261#issuecomment-890498405, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDLZTW6PNJ6OKB47XRK5SDT2UTKRANCNFSM5BK6KDQA .

Flameish commented 3 years ago

If there are errors, they should normally be written to the log but I'm not fully sure as they would be thrown by the PDF library I use for creating PDF. That's why I suggested starting NG from the console (Powershell/CMD on windows via java -jar Novel-Grabber.jar). You might get some more info that way. If it's an error/limitation in the PDF library(I don't think it is), I wont be able to fix this issue easily.

Alternatively you can try converting the EPUB to PDF. There are lots of tool to do that online.

xx255q commented 3 years ago

So I added a number of books and overall were able to do directly to PDF if under 1000 I think. Anything more than that then I would convert to PDF from epub instead.

I noticed when adding a book to my favorites I would have to put in the location of the file twice. Once when first downloading and again in the favorites setting. Would it be possible to automatically have whatever I set for the download location when first downloading a novel to also be the favorites save location?

Also, I noticed I always set the same setting when making a favorite such as turning on auto-downloading with at least 1 chapter and make sure to get a picture and chapter title. Can I have some sort of profile set up so any favorite has those settings enabled?

Flameish commented 3 years ago

I will try to find out what the problem with the PDF library is as there shouldn't be a problem with 1000 chapters in a PDF normally.

Currently, the library will move the downloaded file to either the normal library location(inside the Novel Grabber folder) or if you have specified a default location in settings, there. Maybe that's enough for your use case.

Also, when adding a novel to the library, it will copy the current novel options to the library options (get images, add chapter title, use account). I will add global settings for those(except use account) and the download new chapters option.