[BUG] -getImages not working on cli

[Jakgab617]

Cli -getImages not working Describe the bug

Always Download Images in settings and config. It works in the GUI but not on cli.

Did a normal and headless browsing, input the command before and after the -link parameter. Turned off the getImages in the GUI settings as I thought using it on cli might negate the command.

I can't tell exactly on which update this happened as I haven't really checked until now.

Platform

Windows 10 Pro 64bit Ubuntu 18.04 LTS Ubuntu 20.04 Java SE 11, 13 and 16

[Flameish]

Thanks for the report! I found the error. A search-replace/variable rename changed the command from "getImages" to "autoGetImages". Will be fixed in the next release, until then you can just use -autoGetImages.

[Flameish]

Fixed. Please Update.

[Jakgab617]

Thank you so much!

[Jakgab617]

File rendered with - getImages is big now. 23MB same story file that I downloaded before with images was only 3MB

https://www.wattpad.com/story/182350011-my-future-in-her-past-1st-book-of-%27in-her-past%27

I tried a different story same result 23MB

https://www.wattpad.com/story/165683836-dalaga-na-si-remison

On Mon, Oct 11, 2021, 17:16 Flameish @.***> wrote:

Fixed. Please Update.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Flameish/Novel-Grabber/issues/302#issuecomment-940022251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQORB3VXI4MDJPIODMLS43UGLPTJANCNFSM5FWYRAIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[Flameish]

Images seem to be much bigger. Will take a look.

[Jakgab617]

It's not your code? Because both link rendered 23MB files. Compared to a much smaller files from a calibre plugin.

On Tue, Oct 12, 2021, 13:04 Flameish @.***> wrote:

Images seem to be much bigger.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Flameish/Novel-Grabber/issues/302#issuecomment-940814229, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQORB3V7ZTFH5I3DAYZXLDUGP23PANCNFSM5FWYRAIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[Flameish]

Yes, the images created by NG are much bigger is what I meant.

[Jakgab617]

I usually have the NG grab the images and it is not this big before. Any chance it will be smaller on the next update?

On Tue, Oct 12, 2021, 15:24 Flameish @.***> wrote:

Yes, the images created by NG are much bigger is what I meant.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Flameish/Novel-Grabber/issues/302#issuecomment-940917844, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQORB2RHFKK5YHDT4UIZ2LUGQLHZANCNFSM5FWYRAIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.