No page numbers to click on on new profiles

FlandreDaisuki / Patchouli

An image searching and browsing tool on pixiv

MIT License

80 stars 6 forks source link

No page numbers to click on on new profiles #41

Closed ghost closed 5 years ago

ghost commented 5 years ago

Describe the bug

As the title says, there are no page numbers to click on on the new profile designs, on any tab.

Steps to reproduce

Go to a profile page on any tab, scroll down, no page numbers to click on.

Screenshots

(script off)

(script on)

of course this happens on tabs with multiple pages too.

Environment

Windows 10 Firefox 67.0.2 64-bit Tampermonkey Version 4.2.2

FlandreDaisuki commented 5 years ago

Thanks your feedback first.

Actually, this is not a bug. The usage of Patchouli doesn't need pagination. If I add pagination as its function, it will be confused that click Go to find before or after current page. So, if you like pagination-based navigation to browse images, Patchouli maybe not a good tool for you.

ghost commented 5 years ago

Was this changed recently? I used to have pages on search pages. I would like to have both infinite loading and pages.

FlandreDaisuki commented 5 years ago

No. The last time I change the code is https://github.com/FlandreDaisuki/Patchouli/commit/312db4592cdbd56199f3982df249c8fac205f5d2 , in 2019/1/10, v4.2.2.

OK, I'll take a look about this issue.

FlandreDaisuki commented 5 years ago

I test following urls, which is the page link you click:

When Patchouli turns on, it shows the same results. I don't know whether your pixiv will show the same results.

If it's the same, that the pagination is meaningless.
If it's different, I can't reproduce this bug on my machine, maybe pixiv is doing some testing on your account.

ghost commented 5 years ago

I recently switched from Greasemonkey with a good amount of extra pixiv userscripts to Tampermokey with just Patchouli. That could be why pages behaved differently before.

I tried the links and got the same results. In any case I personally found numbered pages easier to navigate, especially for profiles with a lot of content. I will continue using Patchouli regardless so consider it a suggestion.