fix: Remove usage of secrets to fix failing builds

Flank / flank

:speedboat: Massively parallel Android and iOS test runner for Firebase Test Lab

https://firebase.community/

Apache License 2.0

672 stars 113 forks source link

fix: Remove usage of secrets to fix failing builds #2369

Closed rfogar2 closed 1 year ago

rfogar2 commented 1 year ago

Fixes #

Illegal use of secrets, see comment in this PR for more context

https://github.com/Flank/flank/pull/2360

I'm working on a way to resolve the original issue (rate-limiting) without breaking things, but this pull request will at least fix the new problem in the meantime.

Test Plan

How do we know the code works?

Checklist

[ ] Documented
[ ] Unit tested
[ ] Integration tests updated

rfogar2 commented 1 year ago

@Fry-kun can you approve and merge this? I'm aware this will be breaking things for a lot of people.

adamvduke commented 1 year ago

Seems like this partial rollback of #2360 should be safe, because there is a guard against adding the token to the request if it's blank, and it wasn't being passed previously.

https://github.com/Flank/flank/blob/3a213579b0b8ed7ca018314f0619146408292b35/flank-scripts/src/main/kotlin/flank/scripts/data/github/GithubApi.kt#L197-L201