Closed adamvduke closed 1 year ago
Timestamp: 2023-06-08 16:32:39 Buildscan url for ubuntu-workflow run 5213506128
@flank-it
Integration tests failed :x: Windows status failure - Build scan: MacOS status failure - Build scan: Linux status failure - Build scan: Workflow run https://github.com/Flank/flank/actions/runs/5204682101
@flank-it
Integration tests succeed for all OSs :white_check_mark: Windows Build scan: MacOS Build scan: Linux Build scan: Workflow run https://github.com/Flank/flank/actions/runs/5205134125
@flank-it
Integration tests succeed for all OSs :white_check_mark: Windows Build scan: MacOS Build scan: Linux Build scan: Workflow run https://github.com/Flank/flank/actions/runs/5212971863
@flank-it
Integration tests succeed for all OSs :white_check_mark: Windows Build scan: MacOS Build scan: Linux Build scan: Workflow run https://github.com/Flank/flank/actions/runs/5213655692
Fixes #2372
This change seems large because it is deleting a significant amount of vendored/generated code. Functionally, the bulk of the change is updating a handful of dependencies, which includes a dependency was previously vendored/generated, but can use a pre-built artifact going forward.
Everything under firebase_apis/test_api is vendored/generated based on the json API discovery document for the testing API or similar. Based on this comment, it seems like this was done to leverage code that wasn't available as part of the publicly available testing api jar at the time. The unit and integration tests pass using the currently available testing api jar, and so it's no longer necessary to maintain the firebase_apis/test_api sub-project, and flank can depend on the newest/current publicly available jar.
Test Plan
Unit and integration tests are still passing
Checklist