fix: set correct max test shards when arm devices are configured

[adamvduke]

Current correct behavior:

• If max-test-shards is set to -1, AND ONLY physical devices are configured, Flank will adjust max-test-shards to the upper limit for physical devices
• If max-test-shards is set to -1, AND ONLY virtual devices are configured, Flank will adjust max-test-shards to the upper limit for virtual devices
• If max-test-shards is set to a value higher than the upper limit for physical devices AND ONLY physical devices are configured, Flank will throw a configuration error
• If max-test-shards is set to a value higher than the upper limit for physical devices AND BOTH physical and virtual devices are configured, Flank will adjust max-test-shards to the upper limit for physical devices
• If max-test-shards is set to a value higher than the upper limit for virtual devices, Flank will throw a configuration error

Current incorrect behavior:

• If max-test-shards is set to -1, and ARM devices are configured, Flank will adjust max-test-shards to the upper limit for virtual devices, which is currently higher than the documented upper limit for ARM devices
• If max-test-shards is set to a value higher than the upper limit for ARM devices and ARM devices are configured, Flank will adjust max-test-shards to the upper limit for virtual devices, which is currently higher than the documented upper limit for ARM devices

New behavior:

• If max-test-shards is set to -1, and ARM devices are configured, Flank will adjust max-test-shards to the upper limit for ARM devices
• If max-test-shards is set to a value higher than the upper limit for ARM devices AND ONLY ARM devices are configured, Flank will throw a configuration error
• If max-test-shards is set to a value higher than the upper limit for ARM devices AND BOTH ARM and non-ARM devices are configured, Flank will adjust max-test-shards to the upper limit for ARM devices

Fixes #2401

• [ ] Documented
• [X] Unit tested
• [ ] Integration tests updated

[github-actions[bot]]

Timestamp: 2023-07-12 17:53:37 Buildscan url for ubuntu-workflow run 5534790242

[adamvduke]

@flank-it

[github-actions[bot]]

Integration tests succeed for all OSs :white_check_mark: Windows Build scan: MacOS Build scan: Linux Build scan: Workflow run https://github.com/Flank/flank/actions/runs/5534820792