search

Flanks255 / simply-graves

Simple Grave mod for forge.
MIT License
2 stars 1 forks source link

Backpack does not return baubles to bauble slots. #2

Open AryuSyrius opened 1 year ago

AryuSyrius commented 1 year ago

Describe the bug When you right click on the grave, and you had a full inventory, it drops the excess items on the ground. This is due to armor and baubles not returning to the bauble slots or equipment slots. Making it very easy to lose items.

Screenshots If applicable, add screenshots to help explain your problem.

Please try to give as much info as possible.

If it is a crash, please provide the crash-log through a website like http://pastebin.com or https://gist.github.com/

Please provide the version of forge used, and the mod version. 1.20.1-1.0.7-build.8 47.1.76 forge ftb direwolf 1.20 modpack

Flanks255 commented 1 year ago

Ya, this isnt just backpacks, and its not technically a bug, as you would drop everything, and you pick it all up and its the same result, i have been trying to come up with a good way of handling this, as i dont get any information on where items were equipped, i just get a list of items when you die.

AryuSyrius commented 1 year ago

Could you keep the overflow items in the grave and pop a message saying your inventory is full. Like if the number of items exceed the max vanilla inventory size, just retrieve the first set and keep the grave to be right clicked again?

CoolLord22 commented 8 months ago

Wanted to add onto this issue; same results with slots from CosmeticArmor, Curios, and armor in general.

I know enigmatic graves has built in patches for this, was wondering if you’d had a chance to look through how it’s done there and implement something similar for SimplyGraves. See links for source below! I wonder if there’s a way to grab the players inventory on that death event and compare to see if the items are in the inventory slots 0-35(?) and if not, they’re in a different slot maybe?

I can also try to work on a PR in my free time to help code this in if you’re interested, lmk! :)

Flanks255 commented 8 months ago

its being worked on already.