FlansMods / FlansMod

Flan's Mod for Minecraft
Other
236 stars 149 forks source link

[1.12] no longer compatible with potioncore archery effect #1164

Open mensreaMC opened 4 years ago

mensreaMC commented 4 years ago

The mod potioncore's archery effect used to be able to increase bullet damage by a configurable amount of damage per level of the archery effect. At some point this stopped working, still not sure where. The effect still works with arrows from vanilla MC, just no longer bullets.

Steps to reproduce the behaviour:

  1. use the potioncore archery effect
  2. fire a gun
  3. gun does no extra damage

The gun should do at least X extra damage, where X is what was set in the config.

I know this is probably not that important in the grand scheme of things but it was a really useful effect for pack makers.

Liruxo commented 4 years ago

I do not see this as a bug, bullets are not arrows. In my opinion this is a feature request and as such i deem it as confusing behavior when bullets get the same effect as arrow. You may ask potioncore to include FlansMod compatibility, as they have a much better control over the intended behavior and additional configuration options. It should be possible to add a global FlansMod damage modifier, however it is also quite easy to manually change the damage value of guns in the content packs for yourself