FlansMods / FlansMod

Flan's Mod for Minecraft
Other
236 stars 149 forks source link

Weapons Boxes can't use oredict in recipes #1422

Open JT2AW15 opened 2 years ago

JT2AW15 commented 2 years ago

Describe the bug Weapons Boxes do not properly interact with ore dictionary items

To Reproduce Steps to reproduce the behavior:

  1. Ensure that a weapons box uses ingotSteel or other ore dictionary item as a part of one of its recipes
  2. Place the weapons box and interact with it
  3. Observe that instead of ingotSteel or other ore dictionary item, there is just a green check box as if the requirement is satisfied. The ingotSteel or other isn't in the box with the required quantity listed. It's not just visual, the requirement is waived. If you have the other required items, or if that was the only required item, you can get the product item without spending the ingotSteel(s) or other item.

Expected behavior Weapons boxes should require all materials as specified in their .txt file. Ore dictionary should be supported, and if ore dictionary materials are not found, should go to the fallback recipes as in https://github.com/FlansMods/FlansMod/commit/a61ad7c375dc4384f3c4a2cdf4d87d6f8f2dbe83

Screenshots 2021-12-06_17 19 06

Versions

Additional context Note: There are no issues with ore dictionary items being used in the crafting table to create Flan's Mod items. It's just when they are being used to create other items through a weapons box (or potentially a vehicle box, but the content packs I am working with do not have any recipes like this). 2021-12-07_16 35 25

The debug.log: https://gist.github.com/aw11man/a0b215870b1f50dece6dcfbc5d703604 Lots of [Client thread/WARN] [flansmod]: Could not find ingotSteel in recipe

JT2AW15 commented 2 years ago

EDIT: I didn't realize that the default recipes for Modern Weapons 5.10.0 all had ingotIron not ingotSteel 😅 as of https://github.com/FlansMods/FlansMod/commit/c996524b5ec30ded426fbae5532d691d8869e7d4 I went back and changed the recipes in the 5.10.0 version to use ingotSteel, and got the same results as above

Update: I built from the github, updating Modern Weapons Content Pack to v5.10.0, which resulted in a slightly different handling of the same issue. I also used the Flan's Mod 5.10.0 and Parts pack 5.10.0 I built for the following testing, replacing the CurseForge downloads.

Previously, ingotSteel and other ore dictionary items couldn't be found, and weren't replaced. Using 5.10.0, ingotSteel couldn't be found, and was replaced with minecraft iron ingots, but treatedPlanks were still bugged, not showing up or being replaced. Notable is that the suite of mods being used has a steelIngot item, but no treatedPlanks item, ironically it replaced the one that doesn't need it, and doesn't replace the one that does.

Pictured is the Executioner Shotgun that uses both ingotSteel and treatedPlanks, 2021-12-07_15 58 44

Interestingly, the crafting table recipes are also broken this time, while they worked fine before. 2021-12-07_16 33 32

The debug.log: https://gist.github.com/aw11man/ea33b116118d6050dcf2d91be577777e No warning about not finding ingotSteel (?), but still [main/WARN] [flansmod]: Could not find treatedPlanks in recipe