coldblade2000
commented
5 years ago I have made SOME progress fixing this, but I'm not experienced with forge enough to go the whole way. The main issues are in EntityDrivable.java's shootEach() method. The first issue, which I managed to solve had to do with Vectors. the gunVec Vector seems to be a local vector, and is never added to the player's coordinates, so the gunVec points to coordinates within a few blocks of 0,0,0 (Think -2, 1, 2.5 instead of the vehicle's position of 536, 64, -1850). I solve this by instead doing this for gunVec:
Vector3f GunVec = Vector3f.add(new Vector3f(posX, posY, posZ), getOrigin(shootPoint), null);
I used a debug chat message to tell me where the bullet would hit.
https://gist.github.com/coldblade2000/59ba2acf7420bb201df7862fea303bf0 in line 615
Finally, this is the main problem I've noticed. Flans tries to use ServerHandleShotData in ItemGun to register the bullets, but then ServerHandleShotData quickly returns nothing, as the first thing SeverHandleShotData does is check if the "entity" given is an instance of EntityPlayerMP (which it isn't, its a tank, plane, etc). Thus, nothing else runs. I can go further into detail if needed. Point is, the shotData is just never handled, thus nothing else happens
Edit: I realize the code is badly formatted, give me a sec
Edit 2: https://gist.github.com/coldblade2000/59ba2acf7420bb201df7862fea303bf0
Simpyo
ChrisLane
itsyaboiiOliver
Datboi727
Liruxo
Xeladin
RafaelJunior1
Version: 5.5.2 (main download from https://flansmod.com/download)
Minecraft Version: 1.12.2
Issue: Secondary guns for any vehicle do not seem to function; while (for example) bombs function on right-click for planes with them, using left click, right click or the default hotkey (have tried changing the hotkey but to no effect) does not fire the secondary guns. A good example is the Fokker's machine guns not firing as they count as a secondary gun.