search

Flared / dramatiq-abort

Dramatiq extension to abort message
http://flared.github.io/dramatiq-abort
GNU Lesser General Public License v3.0
40 stars 15 forks source link

Add support for gevent #12

Closed FinnLidbetter closed 3 years ago

FinnLidbetter commented 3 years ago

Fixes #11.

Gevent has been integrated into the tox build process the same as it is currently in the dramatiq project.

Added tests for log messages.

It could be good to wait until the next Dramatiq release such that is_gevent_active can be imported from dramatiq, rather than being re-defined here. But I'm not sure how soon that will be.

isra17 commented 3 years ago

One small nit, otherwise LGTM!

isra17 commented 3 years ago

I fixed the CI on master, can you rebase? Thanks!

FinnLidbetter commented 3 years ago

Ok great, thanks! I resolved the merge conflict through the UI here. Is this ok? I'm familiar with Gerrit but not GitHub for rebasing changes and I wasn't sure if pushing my locally rebased branch would still be associated with this same PR or whether it would be a new PR and whether or not that is desirable. I can push this change rebased on master as a single commit if that is preferable.

isra17 commented 3 years ago

Thanks! I manually merge in master after rebasing to avoid the extra merge commit.