search

Flared / dramatiq-abort

Dramatiq extension to abort message
http://flared.github.io/dramatiq-abort
GNU Lesser General Public License v3.0
40 stars 15 forks source link

feature: Support two abort mode. `cancel` to abort the pending task, … #7

Closed JetDrag closed 2 years ago

JetDrag commented 3 years ago

feature: Support two abort mode. cancel to abort the pending task, and the default abort to abort the pending or running task.

JetDrag commented 3 years ago

Hi, @isra17 I just open a new clean PR for review.

JetDrag commented 3 years ago

Hi, @isra17 I just updated the code and resolved the all discussion. Review again please.

Sorry for the delay because of my busy work.

JetDrag commented 3 years ago

Hi @isra17, do you have time to review the change and release a new version? So we don't have to deploy a custom version in out production environment.

JetDrag commented 3 years ago

Hi, @isra17, I've resolved the all discussion. Thanks for your patient, review again please.

JetDrag commented 2 years ago

I've resolved the recent discussion，review again pls.

isra17 commented 2 years ago

Thank you for your work!

isra17 commented 2 years ago

This is released in 0.4.0!

JetDrag commented 2 years ago

Thank you @isra17

JetDrag commented 2 years ago

But there is still a problem that the doc is not up to date anywhere. It seems that the doc is at version 0.1.x. @isra17

isra17 commented 2 years ago

Fixed the github action, should work now