[1.18.x] Epic Fight weapons causing damage to NPCs

[Catomax262]

I kinda hate this, because a normally harmless NPC can't be hit with swords and weapons, neither bare fist attacks or trident attacks with EF (which causes it to take ghost damage, basically not taking damage but still being hit and blinking red), but the NPC DOES take damage when you attack it with any kind of weapon (swords, pickaxes, shovels, all EF weapons except knuckles, etc). This may ruin many RPG maps with EF included. A fix to this may be to add a checkbox to enable if the NPC is set with the IsInvulnerable tag to 1, meaning it can't take any form of damage as long that that box has a tick.

[TheirOwn]

That sounds like a good suggestion. Also would allow for npcs to be on fire or something I suppose. I'll look into this one and see if it can be implemented before the next release.

[FlashHUN]

Huh, turns out they don't have the invulnerable tag. I was pretty sure they did by default at one point, maybe there were some issues with it before that made me remove it. Either way, it's weird that EF can damage NPCs since damage events are canceled here. Does setting an NPC's invulnerable tag to 1 prevent it from being damaged by attacks with EF completely?

[Catomax262]

Does setting an NPC's invulnerable tag to 1 prevent it from being damaged by attacks with EF completely?

Apparently it doesn't. I thought EF didn't ignore this tag at all. How can we circumvent this?

[FlashHUN]

Remove EF from your mods /s

I suggest making an issue on their issue tracker that invulnerable tags and damage events being cancelled don't matter to the mod at all, you can still damage mobs that these conditions apply to. There's nothing I can do on my side to fix this.

[Catomax262]

Best i can do is notify the creator of EF about this.