FlashpointProject / FlashpointUltimateUpdater

Updater for BlueMaxima's Flashpoint
67 stars 10 forks source link

Several URLs are failing #7

Closed ghost closed 1 year ago

ghost commented 2 years ago

Several URLs are failing to download. Below are some of the URLs that are showing up in the log.

https://unstable.life/updater-data/101/Legacy/htdocs/apis.google.com/js/rpc%253Ashindig_random.js%40onload%3Dinit https://unstable.life/updater-data/101/Legacy/htdocs/apis.google.com/js/rpc%253Ashindig_random.js https://unstable.life/updater-data/101/Legacy/htdocs/animuchan.net/moz_game/media%252Fbg.png https://unstable.life/updater-data/101/Legacy/htdocs/4.bp.blogspot.com/-Oj9i-hYRjx4/TZWKtpK_JYI/AAAAAAAADJI/ihwBjr52muY/s1600/EE%2BRostos%2B%25289%2529%255B1%255D.JPG https://unstable.life/updater-data/101/Legacy/htdocs/api-widget.soundcloud.com/media/soundcloud%253Atracks%253A129924353/2a291918-e965-41be-95b4-baab7530e170/stream/hls https://unstable.life/updater-data/101/Legacy/htdocs/disney.go.com/disneytelevision/disney1/characters/doug/doug.html%253fback%253dmain%2526submenu

ghost commented 2 years ago

While continuing to download Flashpoint Ultimate, I did discover one of the reasons that the files above were failing. The file name needs to be encoded.

For example, this was one of the URLs in the log file from the updater tool. If you go to it in a web browser it doesn't work: https://unstable.life/updater-data/101/Legacy/htdocs/apis.google.com/js/rpc%253Ashindig_random.js%40onload%3Dinit

If you encode the file name, it does work. My guess is the tool isn't encoding the URL properly: https://unstable.life/updater-data/101/Legacy/htdocs/apis.google.com/js/rpc%25253Ashindig_random.js%2540onload%253Dinit

Edit: Also to clarify, I am running the tool on Linux. I'm not sure if that would be part of the issue or not.

puigru commented 2 years ago

Well.. it should be encoding the path properly: https://github.com/FlashpointProject/FlashpointUltimateUpdater/blob/fd3c5d34afbb7296c43bfa3d4df2e732b5a8a3c0/update.py#L66

>>> quote('Legacy/htdocs/apis.google.com/js/rpc%253Ashindig_random.js%40onload%3Dinit')
'Legacy/htdocs/apis.google.com/js/rpc%25253Ashindig_random.js%2540onload%253Dinit'

Needs to be investigated further.

parkerlreed commented 2 years ago

I'm seeing this with %252F in the URLs. Supposedly it's a / but that doesn't work either

Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/api.flickr.com/services/feeds/photos_public.gne%40tags%3D%C3%A9%C2%A2%C2%A8%C3%A6%2599%C2%AF%26format%3Drss_200)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/4.bp.blogspot.com/-Oj9i-hYRjx4/TZWKtpK_JYI/AAAAAAAADJI/ihwBjr52muY/s1600/EE%2BRostos%2B%25289%2529%255B1%255D.JPG)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/apis.google.com/js/rpc%253Ashindig_random.js)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/disney.go.com/disneytelevision/disney1/characters/.html%253fback%253dmain%2526submenu%253dshows)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/disney.go.com/disneytelevision/disney1/characters/.html%253fback%253dmain%2526submenu%253dshows)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/apis.google.com/js/rpc%253Ashindig_random.js%40onload%3Dinit)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/api.flickr.com/services/feeds/photos_public.gne%40tags%3D%C3%A9%C2%A2%C2%A8%C3%A6%2599%C2%AF%26format%3Drss_200)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/api-widget.soundcloud.com/media/soundcloud%253Atracks%253A129924353/2a291918-e965-41be-95b4-baab7530e170/stream/hls)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/animuchan.net/moz_game/media%252Fbg.png)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/api.flickr.com/services/feeds/photos_public.gne%40tags%3D%C3%A9%C2%A2%C2%A8%C3%A6%2599%C2%AF%26format%3Drss_200)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/animuchan.net/moz_game/media%252Fbg.png)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/apis.google.com/js/rpc%253Ashindig_random.js)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/disney.go.com/disneytelevision/disney1/characters/.html%253fback%253dmain%2526submenu%253dshows)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/apis.google.com/js/rpc%253Ashindig_random.js)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/apis.google.com/js/rpc%253Ashindig_random.js%40onload%3Dinit)
Giving up download_file(...) after 1 tries (requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://unstable.life/updater-data/110/Legacy/htdocs/4.bp.blogspot.com/-Oj9i-hYRjx4/TZWKtpK_JYI/AAAAAAAADJI/ihwBjr52muY/s1600/EE%2BRostos%2B%25289%2529%255B1%255D.JPG)
parkerlreed commented 2 years ago

This is preventing a good chunk of 11.0 from downloading. Stopped at 1.1 TB

puigru commented 2 years ago

This seems related to #2. The update server appears to have some issues with certain encoded paths. I've let Dri0m know.

Geemer commented 1 year ago

Hi, I'm having the same issue, but on URL: https://unstable.life/updater-data/110/Legacy/htdocs/www.nick.comavatarscape/www.nick.com/avatarescape/index.jhtml%253f_requestid%253d5262732%2526_requestid%253d5379618%2526post%253dtrue%2526_DARGS%253d/common/login/newLogin/form.jhtml%2526_DARGS%253d/common/login/newLogin/form.jhtml

I tried to fix up the % encoding tags as best as I could but that didn't help either.

Geemer commented 1 year ago

Worked around it by creating a dummy file with the expected hash as filename and stuffing that into the .tmp folder.

parkerlreed commented 1 year ago

Did this ever get resolved?