FlashpointProject / launcher

Launcher for Flashpoint Archive
https://flashpointarchive.org
Other
991 stars 55 forks source link

Disable hardware acceleration by default #295

Closed n0samu closed 2 years ago

n0samu commented 2 years ago

Is your feature request related to a problem? Please describe. A lot of users have trouble running Flashpoint Launcher with hardware acceleration. That's why we created this Extended FAQ entry: https://bluemaxima.org/flashpoint/datahub/Extended_FAQ#LauncherBlackScreen

Describe the solution you'd like I think the launcher should be run with hardware acceleration disabled by default. This will allow the launcher to work on a wider range of computers without making users jump through hoops.

Describe alternatives you've considered In my own tests, disabling hardware acceleration didn't really seem to impact launcher performance. But if performance is a concern, I guess there should be a setting on the Config tab to enable hardware acceleration (and disable it by default). Or maybe the launcher could somehow detect when it fails to render correctly and automatically turn off hardware acceleration, but keep it enabled by default?

Additional context Often, this problem manifests as a fully black/grey screen. But sometimes users get even more interesting glitches like this: image Disabling hardware acceleration fixes these as well.

LindirQuenya commented 2 years ago

It's not a hardware acceleration bug, it's a hardware acceleration feature! Just look at those pretty patterns. More seriously, I think that the easiest way to handle this is by changing the launch script/lnk to include the --disable-gpu option.

n0samu commented 2 years ago

That would only work for people who actually use the Start Flashpoint shortcut. We can definitely do that if people agree we should, though.

colin969 commented 2 years ago

Changed in 9b6aa9b818fb72ad18642cc9715efd4d771bbf9b