FlashpointProject / launcher

Launcher for Flashpoint Archive
https://flashpointarchive.org
Other
941 stars 54 forks source link

[BUG] Flashpoint Path not resolved in services.json <fpPath> variable substitution #413

Closed n0samu closed 4 months ago

n0samu commented 8 months ago

Describe the bug Some entries in services.json use the <fpPath> variable, but the launcher substitutes the variable for the literal flashpointPath value instead of the resolved path. This can cause service software to malfunction two reasons:

To Reproduce Steps to reproduce the behavior:

  1. Make sure the flashpointPath is set to ../ in the Launcher's config.json, as it is by default in Flashpoint.
  2. Make sure that services.json is passing a config path to the Apache service using the -f argument and <fpPath>.
  3. Switch the server to Apache Ultimate Webserver and restart the launcher.
  4. Look at the Logs and notice that the Apache server fails to start because an invalid config path was passed to it.

Expected behavior The Apache server should start correctly when a config path is passed to it through services.json.

Desktop (please complete the following information):

n0samu commented 8 months ago

See also: https://gitlab.unstable.life/flashpoint/components/core/configuration/-/merge_requests/3