FlashyReese / sodium-extra-fabric

Features that shouldn't be in Sodium.
GNU Lesser General Public License v3.0
263 stars 65 forks source link

Button not working #177

Closed ChrqnosMC closed 2 years ago

ChrqnosMC commented 2 years ago

Make sure you are not opening a duplicate.

Minecraft version.

1.18.2

Sodium Extra version.

0.4.3

Sodium version.

0.4.1

What happened?

The screen to suggest Reese's Sodium Options works perfectly however the button to access the sodium settings are not accessible. The access button does not work

Relevant log.

[18:14:52] [main/INFO]: Loading Minecraft 1.18.2 with Fabric Loader 0.13.3 [18:14:52] [main/WARN]: Warnings were found!

Additional information.

No response

FlashyReese commented 2 years ago

The screen to suggest Reese's Sodium Options works perfectly however the button to access the sodium settings are not accessible. The access button does not work

Can you elaborate more? As far as changes go the update just checks if you have Reese's Sodium Options installed and makes a suggestion if you don't. Sodium Extra doesn't touch the Video Settings Button, it adds the tabs pages into Sodium's page itself.

MSandro commented 2 years ago

same in 1.17.1 it is because of this mod: https://www.curseforge.com/minecraft/mc-mods/better-sodium-video-settings-button

[07:34:54] [Render thread/INFO]: [STDERR]: java.lang.NoSuchMethodException: me.flashyreese.mods.reeses_sodium_options.client.gui.SodiumVideoOptionsScreen.<init>(net.minecraft.class_437)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/java.lang.Class.getConstructor0(Class.java:3585)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/java.lang.Class.getConstructor(Class.java:2271)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_446.flashyReesesOptionsScreen(class_446.java:553)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_446.md99289e$lambda$mixinInit$0$0(class_446.java:542)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_4185.method_25306(class_4185.java:40)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_4264.method_25348(class_4264.java:16)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_339.method_25402(class_339.java:121)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_4069.method_25402(class_4069.java:27)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_446.method_25402(class_446.java:90)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_312.method_1611(class_312.java:94)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_437.method_25412(class_437.java:490)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_312.method_1601(class_312.java:94)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_312.method_22686(class_312.java:165)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_1255.execute(class_1255.java:101)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_312.method_22684(class_312.java:165)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:36)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.lwjgl.system.JNI.invokeV(Native Method)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3101)
[07:34:54] [Render thread/INFO]: [STDERR]:  at com.mojang.blaze3d.systems.RenderSystem.flipFrame(RenderSystem.java:165)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_1041.method_15998(class_1041.java:310)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_310.method_1523(class_310.java:1137)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_310.method_1514(class_310.java:728)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.client.main.Main.main(Main.java:217)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/java.lang.reflect.Method.invoke(Method.java:568)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:416)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/java.lang.reflect.Method.invoke(Method.java:568)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.multimc.EntryPoint.listen(EntryPoint.java:143)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.multimc.EntryPoint.main(EntryPoint.java:34)
[07:34:54] [Render thread/INFO]: [STDERR]: java.lang.NullPointerException: Cannot invoke "java.lang.reflect.Constructor.newInstance(Object[])" because "this.SodiumVideoOptionsScreenClassCtor" is null
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_446.flashyReesesOptionsScreen(class_446.java:560)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_446.md99289e$lambda$mixinInit$0$0(class_446.java:542)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_4185.method_25306(class_4185.java:40)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_4264.method_25348(class_4264.java:16)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_339.method_25402(class_339.java:121)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_4069.method_25402(class_4069.java:27)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_446.method_25402(class_446.java:90)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_312.method_1611(class_312.java:94)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_437.method_25412(class_437.java:490)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_312.method_1601(class_312.java:94)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_312.method_22686(class_312.java:165)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_1255.execute(class_1255.java:101)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_312.method_22684(class_312.java:165)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:36)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.lwjgl.system.JNI.invokeV(Native Method)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3101)
[07:34:54] [Render thread/INFO]: [STDERR]:  at com.mojang.blaze3d.systems.RenderSystem.flipFrame(RenderSystem.java:165)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_1041.method_15998(class_1041.java:310)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_310.method_1523(class_310.java:1137)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.class_310.method_1514(class_310.java:728)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.minecraft.client.main.Main.main(Main.java:217)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/java.lang.reflect.Method.invoke(Method.java:568)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:416)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
[07:34:54] [Render thread/INFO]: [STDERR]:  at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[07:34:54] [Render thread/INFO]: [STDERR]:  at java.base/java.lang.reflect.Method.invoke(Method.java:568)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.multimc.EntryPoint.listen(EntryPoint.java:143)
[07:34:54] [Render thread/INFO]: [STDERR]:  at org.multimc.EntryPoint.main(EntryPoint.java:34)
FlashyReese commented 2 years ago

This is an issue on better-sodium-video-settings-button's end, I can't do anything here.