FlashyReese / sodium-extra-fabric

Features that shouldn't be in Sodium.
GNU Lesser General Public License v3.0
259 stars 67 forks source link

Minecraft has a weird red border on macOS #297

Open AerodDev opened 1 year ago

AerodDev commented 1 year ago

Make sure you are not opening a duplicate.

Minecraft version.

1.19.3

Sodium Extra version.

0.4.16

Sodium version.

0.4.8

What happened?

Snímek obrazovky 2023-01-03 v 14 35 08 Basically every time I start Minecraft with this mod installed, the screen gets resized weirdly like this leaving an empty red area next to it. This ain't the first version that has that bug, it has also been a thing on 1.19.2. It doesn't happen without this mod and it can be fixed by resizing the window, though its still a bit annoying.

Relevant log.

latest.log

Additional information.

No response

FlashyReese commented 1 year ago

I think it's probably the Reduce Resolution on macOS under Extras causing it, you can disable it to see if the issue still persists obviously you will lose out on performance. Can you provide me information on what hardware your mac has and what version of macOS are you running?

FlashyReese commented 1 year ago

Can you give this build a test to see if the issue persists when having Reduce Resolution on macOS enabled?

sodium-extra-0.4.16+mc1.19.3-unknown.zip

AerodDev commented 1 year ago

Where do I find that Reduce Resolution setting?

AerodDev commented 1 year ago

By the way, I am running latest macOS Ventura through Hackintosh, OpenCore.

FlashyReese commented 1 year ago

Well, I'm not entirely sure how Apple's Retina works on Hackintosh. 2023-01-04_10 43 46 It can be found on the Extras tab in Video Settings.

iAdrianRobin commented 1 year ago

Can you give this build a test to see if the issue persists when having Reduce Resolution on macOS enabled?

sodium-extra-0.4.16+mc1.19.3-unknown.zip

I had the same issue on a MacBook Air (M1, 2020) 8-Core GPU, 16GB RAM, 1TB SSD running macOS 13.2.1 (22D68) and tested build I had following results:

Szenario: Sodium Extra 0.4.16+mc1.19.2-build.90 "reduces Resolution on macOS" - On = described Issue

Szenario: Sodium Extra 0.4.16+mc1.19.2-build.90 reduces "Resolution on macOS" - Off = Issue gone

Szenario: sodium-extra-0.4.16+mc1.19.3-unknown.zip = Issue gone But Video Settings only show: -General -Quality -Performance -Advanced All other Video settings such as Animations, Particles, Details, Render and Extras are not visible. So toggling the "Resolution on macOS" Setting is not possible with this build.

FlashyReese commented 1 year ago

Szenario: sodium-extra-0.4.16+mc1.19.3-unknown.zip = Issue gone But Video Settings only show: -General -Quality -Performance -Advanced All other Video settings such as Animations, Particles, Details, Render and Extras are not visible. So toggling the "Resolution on macOS" Setting is not possible with this build.

@feldstein-iAR I don't think the mod was loaded properly. Did you install the JAR from the zip? (The one without the -sources.jar file name). If you did can you send me the game's log here?

iAdrianRobin commented 1 year ago

@FlashyReese Yes it seems that I installed it wrong. Now I tested again with a new clean instance just with Sodium installed and no other mods beside "Fabric API", "Reese's Sodium Options" and "Sodium Extra".

for Sodium Extra I tested 0.4.17+mc1.19.3-build.95 vs
sodium-extra-0.4.16+mc1.19.3-unknown

Now i see all the options but they share all the same behaviour "reduces Resolution on macOS" - On = described Issue "Resolution on macOS" - Off = Issue gone

But there is one additional thing I would like to mention that I noticed now while testing. When it has started with this boarder it seems to be a visual glitch only as cursor movement does not align. In fact, it seems that the cursor moves like normal and the buttons get highlited when the mouse hovers over the place they supposed to be, not where they actually appear.

In addition when the game window size gets changed by manual adjusting it even the slightest, or by maximising it and then changed back to window mode everything seems to snap back in to place where it should be and all seems fine.

So maximising to full screen and then back to window mode seems currently a possible work around for all versions i've tested. This also works in my normal setup with other mods installed. Then only the red boot screen would be off center.

Hope this feedback would help you.

FlashyReese commented 1 year ago

It appears that the patch didn't work, and unfortunately, I am unable to debug this issue on a Mac since I don't own one. The only workaround for now is to resize the window.

I'm considering whether to disable this feature by default since it impacts the user experience. However, it does provide a significant performance improvement for Mac users.

If I can access a Mac, I'll work on fixing this issue to improve the user experience.

mrjasonn commented 1 year ago

It appears that the patch didn't work, and unfortunately, I am unable to debug this issue on a Mac since I don't own one. The only workaround for now is to resize the window.

I'm considering whether to disable this feature by default since it impacts the user experience. However, it does provide a significant performance improvement for Mac users.

If I can access a Mac, I'll work on fixing this issue to improve the user experience.

This is a very good idea. Mentioned in #311.

TheFruxz commented 11 months ago

Maybe tell about this bug in the hover message of this option? This would be great and avoid people removing mod-by-mod to find the mod causing this bug.

Imzxhir commented 2 months ago

I just tested to see if the bug is still present and for me, this bug is fixed. I don't see a red border anymore when the "Reduce Resolution on macOS" is enabled.

TheFruxz commented 1 month ago

I just tested to see if the bug is still present and for me, this bug is fixed. I don't see a red border anymore when the "Reduce Resolution on macOS" is enabled.

I just checked it again and on my 1080p monitor (haven't checked other displays/native displays yet) the bug is still present on macOS. Here is a screenshot with the setting disabled after startup:

SCR-20240511-qdmp

and with the setting enabled:

SCR-20240511-qdzg

Imzxhir commented 1 month ago

Weird, I have a 21.5-inch (4096 x 2304) iMac and this issue doesn't affect me. This could affect certain monitors, but I am not sure.