FlashyReese / sodium-extra-fabric

Features that shouldn't be in Sodium.
GNU Lesser General Public License v3.0
259 stars 65 forks source link

Support for MacBook displays with a notch #367

Open morceaudebois opened 7 months ago

morceaudebois commented 7 months ago

Hi! I've been using Sodium Extra for a few years and I love it! I especially love the "reduce resolution on macOS" feature as it allows me to play the game with the native fullscreen mode of macOS instead of the regular Minecraft one, which is really buggy.

There's something a bit frustrating though when I'm playing on my laptop's display (MBP 14). I'm effectively playing in 1512 x 945px (half of 3024 x 1890) which isn't really "full screen" as it's missing the top part of the screen, where the notch is. The true resolution of that display is 3024 x 1964 including the notch area, which means the ideal halved full screen resolution should be 1512 x 982px.

The same logic applies to the other recent Mac laptops (MBP 16 and MBA M2), you have the regular 16:10 aspect ratio + the notch area as a bonus.

e7gbkmfp4bu71

I know it sounds a little convoluted but having that additional row of pixels makes it way more immersive. This is how I usually play (macOS native full screen, reduce resolution toggled, 1512 x 945px):

IMAGE 2023-11-15 20:12:35

And this is what it would look like in the correct aspect ratio (achieved through Minecraft's normal full screen mode, 3024 x 1964px):

IMAGE 2023-11-15 20:12:31

Would really love it if Sodium Extra could support it properly! Thank you 😊

Madis0 commented 6 months ago

If your full screen mode already does it, what else do you expect Sodium Extra to do?

morceaudebois commented 6 months ago

The default Minecraft full screen mode is a really poor user experience on Mac. Whenever you want to switch to the desktop/another app, the game will get minimised into the dock and it takes a few seconds each time. Same thing when you want to go back to it, it’s pretty annoying. It also doesn’t support multiple displays as whenever you click on another app on the other display, the game gets minimised into the dock as well.

With the macOS native full screen mode I’m able to use thanks to Sodium Extra, it all works flawlessly and I can switch from Minecraft to anything else instantly :)