Sodium Extra causes beacons to end on max build limit + FPS counter and coords in extras are rendered when F3 is open

FlashyReese / sodium-extra-fabric

Features that shouldn't be in Sodium.

GNU Lesser General Public License v3.0

259 stars 65 forks source link

Sodium Extra causes beacons to end on max build limit + FPS counter and coords in extras are rendered when F3 is open #378

Closed ImGRUI closed 2 months ago

ImGRUI commented 4 months ago

Make sure you are not opening a duplicate.

[X] I have searched the issue tracker and did not find an issue describing my bug.

Minecraft version.

1.20.1

Sodium Extra version.

0.5.4

Sodium version.

0.5.8

What happened?

When Sodium Extra is installed, beacons end at the build limit (256 for nether and end, 320 for overworld), not at a much higher height than it should be. Issue also persists with single fog on. 2nd issue described in Additional Information.

Relevant log.

With Sodium Extra:

Log: https://mclo.gs/Uv6141T

With only sodium and FAPI:

Log: https://mclo.gs/jWQZQEG

Additional information.

2nd issue with FPS counter and coords:

ItzSkyReed commented 4 months ago

Perhaps it is worth adding an option to change the beam height of the beacon, starting from the world limit and increasing it as a percentage.

ItzSkyReed commented 4 months ago

I ran into this problem when I made a large wall of multicolored beacon, but my road is on y 240 in the nether, because of this, the building looks very bad

mrjasonn commented 4 months ago

Occurs on 1.20.4 as well

ItzSkyReed commented 2 months ago

Occurs on 1.20.5

FlashyReese commented 2 months ago

You can temporarily add render.block.entity=false at .minecraft/config/sodium-extra.properties to disable this. It also disables beacon beam, piston and enchanting table toggles.

Caused by https://github.com/FlashyReese/sodium-extra-fabric/blob/cdb15d75cdca99813b17b4e64c47000940009f8b/src/main/java/me/flashyreese/mods/sodiumextra/mixin/render/block/entity/MixinBeaconBlockEntityRenderer.java#L36

ItzSkyReed commented 2 months ago

Thanks!

dbrighthd commented 1 month ago

You can temporarily add render.block.entity=false at .minecraft/config/sodium-extra.properties to disable this. It also disables beacon beam, piston and enchanting table toggles.

Caused by

https://github.com/FlashyReese/sodium-extra-fabric/blob/cdb15d75cdca99813b17b4e64c47000940009f8b/src/main/java/me/flashyreese/mods/sodiumextra/mixin/render/block/entity/MixinBeaconBlockEntityRenderer.java#L36

I dont mean to necropost, but I tried adding that to my sodium-extra.properties and the issue is still there for me (I can't update my sodium extra because I am still on 1.20.1)

Is there something else I should do?

dbrighthd commented 1 month ago

Oh it seems putting mixin.render.block.entity=false fixed it (putting mixing. before it)