search

FlashyReese / sodium-extra-fabric

Features that shouldn't be in Sodium.
GNU Lesser General Public License v3.0
263 stars 65 forks source link

[Feature request] fsr 1.0 implemenattion #381

Closed copilot-lover closed 6 months ago

copilot-lover commented 7 months ago

HI, I was wondering if you would be interested in implementing FSR 1.0 into Sodium Extras. This would be beneficial because it would allow players with really bad PCs (like me) to play on a lower resolution (for performance) without the quality impacts of no upscaling.

Background I have done lots of Reasearch on fsr improvements and I think it would really help players with ultra-low end pc's like me. Also it has been ported to opengl so it should be easy to include without a lot of extra work converting the glsl to opengl from vulkan.

Impact on players: Imagine the frustration of a player with an outdated PC—struggling to run their favorite game smoothly. They face lag, stuttering, and pixelated visuals. FSR 1.0 changes that narrative. It evokes feelings of relief and excitement as players witness smoother gameplay, even on low-end systems. No more compromises between performance and visual quality.

Details Let's delve into the technical details. FSR 1.0 employs advanced upscaling algorithms that dynamically enhance lower-resolution textures without sacrificing image quality. By intelligently interpolating pixels, it maintains sharpness while significantly boosting frame rates. The result? A win-win situation for both players and developers—better performance without compromising visual fidelity.

By incorporating FSR 1.0 into Sodium Extras, we empower players to enjoy their favorite games on older hardware, fostering inclusivity and expanding our player base. Let's make gaming accessible for everyone!

copilot-lover commented 7 months ago

@FlashyReese

mrjasonn commented 7 months ago

If this is so then DLSS should also be implemented, and this is not so suited for this mod.

AnOpenSauceDev commented 6 months ago

I don't think FSR1 would improve your performance as much as you think, let alone improve the visuals. If you can't run a visually simple game without many complex fragment shaders like Minecraft at 1080p smoothly, FSR is not going to help much. Also FSR1 tends to butcher sharp edges a lot, which can make blocky games look awful.

I actually have tried this out before out of curiosity, but the end result was very underwhelming and blurry, even with CAS maxed out.

Before (640x480)

before fsr

After (1280x960 with FSR1 scaling, fully sharpened)

FSR

After (again, 1280x960, but at 0.5x sharpness)

FSR 50%

As you can see, FSR really isn't worth it for a game with Minecraft's aesthetic. Also, implementing DLSS into Minecraft itself would be incredibly painful to do.

copilot-lover commented 6 months ago

ok thx