Flask-Middleware / flask-security

Quick and simple security for Flask applications
MIT License
624 stars 155 forks source link

German translations for 'confirmation instructions' #917

Closed sr-verde closed 5 months ago

sr-verde commented 5 months ago

In this PR, I am trying to get some better, more user-friendly wording for the German translations of 'confirmation instructions'. Even more, I differ from the English original and try to give the user helpful instructions. So, the current English version is:

Thank you. Confirmation instructions have been sent to user@example.com.

I have translated that to something like:

Thank you. To confirm your email address %(email)s, please click on the link in the email we have just sent to you.

One may want to adapt that for other languages as well.

I also translated "confirmation instructions" to "confirmation link" ("Bestätigungslink"). But "confirmation instructions" doesn't sound as weird (to me as a non-native speaker) as it does in German.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0b971c1) 98.40% compared to head (4e5d898) 98.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #917 +/- ## ======================================= Coverage 98.40% 98.40% ======================================= Files 35 35 Lines 4508 4508 ======================================= Hits 4436 4436 Misses 72 72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jwag956 commented 5 months ago

I'll look into changing the default/English... (and try to keep your translation!).

Thanks.