search

Flask-Middleware / flask-security

Quick and simple security for Flask applications
MIT License
622 stars 154 forks source link

Fix regression when config no longer set as attributes. #952

Closed jwag956 closed 3 months ago

jwag956 commented 3 months ago

In a couple templates 'security.xxx' was referenced - those are no longer set as attributes. Use flask's 'config' context variable instead.

closes #950

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.44%. Comparing base (96e8f04) to head (459d2e4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #952 +/- ## ======================================= Coverage 98.44% 98.44% ======================================= Files 35 35 Lines 4513 4513 ======================================= Hits 4443 4443 Misses 70 70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TimotheeJeannin commented 3 months ago

I think it's till used here too : https://github.com/Flask-Middleware/flask-security/blob/528d9a65b9722346f114f4d96ce7e1bbb6d97a96/flask_security/confirmable.py#L100

In my application the sepecified datetime factory is ignored when the email is confirmed. Is that expected?

jwag956 commented 3 months ago

Another regression - see #959

working on it.