Flat-Badger-1971 / ArchiveHelper

0 stars 1 forks source link

The chosen verse or vision is displayed in group chat but only to one player #19

Closed Stemuweb closed 5 months ago

Stemuweb commented 5 months ago

The addon displays : [Groupe][ArchiveHelper] : X selected Y

but only player X can see the message. The other player in the duo won't see it. It seems the string is displayed locally in the log but not send to the server as if the player wrote it and pressed enter. Maybe a limitation of the API that prevents add-ons to speak publicly?

Possible solution would be a new data sharing command. To keep the index transmitted as the parameter, it could the position of the ability in the AH.ABILITIES array (Bestial Transformation would be 1, Flame Aura 2, etc.)

Flat-Badger-1971 commented 5 months ago

Ah - that's annoying. We could probably send the entire abilityid in a data share as I think the number we can send is quite large.

Flat-Badger-1971 commented 5 months ago

Reworked the share code and added the abilityid to it - not tested yet though

Stemuweb commented 5 months ago

I've read the message integer transmitted should be less than (map size step ^ 2) but I have no idea what the maximum allowed value is. Hence my suggestion to use the array position. I'm getting your last commits and test immediately.

Stemuweb commented 5 months ago

Code lines to actually trigger the data sharing of AH.SHARE.ABILITY seem to be missing in function onChoiceCommitted.

Edit: I've tried adding a line of code (see PR #20) and tested it in game, it works very well with the ability id

Stemuweb commented 5 months ago

Suggestion: to better distinguish between selected verses or visions names, give different colours to the abilities depending of their categories, by re-using the colour codes of items rarities.

Source: https://en.uesp.net/wiki/Template:ESO_Quality_Color

Flat-Badger-1971 commented 5 months ago

Merged your PR, not sure how I managed to miss that bit. Your colours aren't quite correct - the avatar transformations are actually verses not visions, they can appear on any stage once you have all 3 visions.

Stemuweb commented 5 months ago

Ahah, you are right, I always see them as the push-to-win button and never think twice before choosing them, so in my mind, they are better than visions. Anyway, the color choice would stand, they are legendary :) But a different color between verses and visions would be enough. The different colours for avatars would just be to show-off you've been lucky.

Flat-Badger-1971 commented 5 months ago

I've implemented it, just leaving the archive now then I'll push the most recent changes

Stemuweb commented 5 months ago

Great job! I'm still trying to get the filer's wing to collect debug data but no luck today.

Stemuweb commented 5 months ago

Correction: I really mix the avatar verses and versions. By order of importance, it should be:

verse < vision < avatar vision (set) < avatar verse (transformation)

I'll fix my mistake and swap the colours