search

Flat-Badger-1971 / ArchiveHelper

0 stars 1 forks source link

Bug: after getting the avatar transformation verse for the 4th time, a counter was displayed #39

Closed Stemuweb closed 4 months ago

Stemuweb commented 4 months ago

Werewolf behemoth 2

Stemuweb commented 4 months ago

To be clear: I got the 3 visions, then a lucky streak and several times the Werewolf behemoth verse. The first times, the verse counter wasn't printed.

Flat-Badger-1971 commented 4 months ago

How odd - a little tweak to the groupchat should sort that out - assuming transformation don't actually stack and make you extra werewolfy...

Stemuweb commented 4 months ago

I checked your change (while playing). I think you could even write it like this:

            if (avatar) then
               if (abilityType == AH.TYPES.VISION) the,
                  message = message .. " |cffff00(" .. ZO_CachedStrFormat(_G.ARCHIVEHELPER_COUNT, count, 3) .. ")|r"
               end
            elseif (count > 1 and) then
                message = message .. " |cffff00(" .. count .. ")|r"
            end

I'm not sure which one is the least difficult to read ;)

Flat-Badger-1971 commented 4 months ago

Yeah, actually I prefer your version - it's better structured.

Flat-Badger-1971 commented 4 months ago

OK - going to draw a line under this for now so I can get a release out. I'll close this issue - any future problems/ideas can go under new issues then.