Closed Stemuweb closed 5 months ago
Correct again! Added to my local branch.
I looked at your code in marker.lua and better understood your intent. I fought it was limited to the fabled but you are right, Archive helper should not put any marker at all whatever the enemy type is, to avoid creating conflicts.
Then it should imply the following changes to the settings UI:
In settings.lua, the 3 others settings (maraudeur, shard, gw) should also be disabled when Lykeion's addon is detected:
disabled = function() return not AH.CompatibilityCheck() end,
and have the same tooltip:
tooltip = function() if (not AH.CompatibilityCheck()) then ...
as the fabled.
Maybe FABLED_TOOLTIP should be renamed LYKEION_TOOLTIP or CONFLICT_TOOLTIP
but I'm nitpicking 😂
https://github.com/Flat-Badger-1971/ArchiveHelper/blob/47410e0a70e9c0ed533b1fd00c80ed882feb5620/misc/markers.lua#L200-L203
If Lykeons addon is used, it only greys the settings for the Fabled detection.
If I'm not mistaken, the test should be :
(note also that GWCheck must be included too)