search

Flat-Badger-1971 / ArchiveHelper

0 stars 1 forks source link

The 'manual' property in AH.MARKERS is not used #8

Closed Stemuweb closed 5 months ago

Stemuweb commented 5 months ago

https://github.com/Flat-Badger-1971/ArchiveHelper/blob/47410e0a70e9c0ed533b1fd00c80ed882feb5620/misc/markers.lua#L11-L17

It's never set to true, in particular when keybinds functions are used.

I don't know if it should be used at all, because it may not work properly in duo mode.

Flat-Badger-1971 commented 5 months ago

I think it does need to be set, the issue is that without it there's a chance that other marker detection code may just remove it again. I accept there will be in an issue in duo mode, but I may be able to work around that. I'll leave this issue open for now.

Stemuweb commented 5 months ago

Indeen, duo mode is tricky.

Don't worry, use this flag as you see fit. I'll test it while playing and I would report it if I ever had any problems