search

FlatFilers / flatfile-plugins

Library of open-source plugins for developing with the Flatfile Platform
6 stars 7 forks source link

JSON extractor fails to extract any files on 0.9.0 #695

Open amarbakir opened 2 hours ago

amarbakir commented 2 hours ago

Slack logo #triage-eng-support thread

I'm pretty confident JSON extractor release 0.9.0 broke previous behavior. So if you have a working app using 0.8.2 and update to 0.9.0, the 0.9.0 JSON extractor doesn't work for both a valid, populated JSON array as well as an empty array (both cases are handled elegantly in 0.8.2). Both cases fail with this error:

Event Received: file:created
TypeError: Cannot read properties of undefined (reading 'get')
    at Object.callback (/Users/amarbakir/dev/FlatfileApp/.flatfile/develop.js:96647:46)
    at exports.Client.trigger (/Users/amarbakir/dev/FlatfileApp/node_modules/@flatfile/listener/dist/index.cjs:1:6431)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async exports.Client.dispatchEvent (/Users/amarbakir/dev/FlatfileApp/node_modules/@flatfile/listener/dist/index.cjs:1:6214)
    at async Object.message (/Users/amarbakir/dev/FlatfileApp/node_modules/@flatfile/listener-driver-pubsub/dist/index.js:108:17)

Given it was a minor version update, I would expect no breaking changes. Let me know if you'd like any further details on this or help debugging/fixing

Surfaced this here and got a response here: https://github.com/FlatFilers/flatfile-plugins/pull/690#issuecomment-2450780728

Deleting node_modules did not work (tried multiple times when I first saw the issue). Given that PR was able to be tested locally with the @flatfile/util-extractor@2.3.0 update introduced there, I think the suggestion to use @flatfile/util-extractor@2.2.1 is the correct fix. I'll open that change tonight/this weekend if no one else beats me to it :)

Front logo Front conversations

Arsik36 commented 2 hours ago

Hey Amar, our engineers released an update to plugin-json-extractor this morning to update the dependency. Please test again with version 0.9.1 and let me know if you still encounter this behavior!