FlavioFS / godot-pokemon-transitions

Old pokemon-style screen transitions.
MIT License
28 stars 6 forks source link

Confusion between .import/ and *.import files in .gitignore #1

Open Sslaxx opened 5 years ago

Sslaxx commented 5 years ago

I noticed you have **/*.import in your .gitignore file.

This is actually incorrect. You want to ignore the .import directory; the *.import files tell Godot how to handle the files. The .import directory is more of a cache; it can be safely .gitignore-d. There is an issue about this on the Godot issue tracker - https://github.com/godotengine/godot/issues/23368

https://github.com/Sslaxx/Godot_Sonic_Engine/blob/master/.gitignore or something like this might be a useful .gitignore to use.

FlavioFS commented 5 years ago

I noticed you have **/*.import in your .gitignore file.

This is actually incorrect. You want to ignore the .import directory; the *.import files tell Godot how to handle the files. The .import directory is more of a cache; it can be safely .gitignore-d. There is an issue about this on the Godot issue tracker - godotengine/godot#23368

https://github.com/Sslaxx/Godot_Sonic_Engine/blob/master/.gitignore or something like this might be a useful .gitignore to use.

Thank you for your feedback. 😁

Handling those metafiles is a weakpoint of mine. At the time I wrote that ignore I just wanted to remove all import files from repo.

But now that you mentioned it I am concerned that those imported files won't be handled properly as Pixel Arts, specially the textures that should apply no Filter.

Weird enough, I have tested this and it worked. I've cloned the repo in a new folder, executed the project and the imports still didn't apply any filter. Maybe I've set no filter as default and Godot is correctly auto-generating that stuff but only in my machine.