Flaxbeard / ImmersivePetroleum

Oil and oil processing for Immersive Engineering
https://minecraft.curseforge.com/projects/immersive-petroleum
56 stars 61 forks source link

Distillation tower disappearing, teleporting #139

Open P10B opened 5 years ago

P10B commented 5 years ago

FTB Continuum 1.5.2 & Continuum server 1.5.2 Immersive Petroleum 1.1.9

After completing the distillation tower multiblock and activating it by right-clicking the redstone engineering block with an engineer's hammer, strange issues begin to arise. The 3D mesh that replaces the individual blocks will form correctly at first, but at random intervals of 2-15 seconds it will either offset and rotate ('teleport') a few blocks to a consistent location or disappear entirely. Opening the distillation tower's inventory will cause the 3d mesh to reappear in the teleported position, while closing it will reset the mesh to it's correct state... whereupon it will eventually teleport and/or disappear again.

Deconstructing the multiblock and rebuilding it in a different location yielded no change. Blocks that interact with the tower's inventory sometimes seem to reset the mesh automatically (It will teleport or vanish for a split second and then immediately return to normal), but I have not been able to replicate this behavior reliably.

Shown is the distillation tower in it's correct state, teleported state, and vanished state.

[EDIT - isolated a symptom, found it to be unrelated.]

Update - other players connected to the server are also complaining about similar symptoms.

normal teleported disappeared

P10B commented 5 years ago

I tested this issue with another player present and the visual states appear to be synchronized across all clients. Perhaps this suggests an issue with the server?

ExDomino commented 5 years ago

I think the distillation tower when finished is an entity and maybe another mod considers it's a living entity and teleport it randomly. Your modpack is named Continuum so it's a possibility. Can you test is the problem occur in singleplayer? If so, you can remove each mods on the modpack one by one to find out the mod that cause this problem.

Flaxbeard commented 4 years ago

Marking as bug but seems difficult to diagnose at the moment. Would appreciate any replication instructions.

YAPNie commented 4 years ago

Got the same issue, tried to find a solution but found only this issue. So, just for history leave my notes (I play single mode):

  1. SevTech Ages v3.0.8 - NO issue.
  2. SevTech Ages v3.1.2 hotfix 1 and v3.1.7 - issue presents.

If so, you can remove each mods on the modpack one by one to find out the mod that cause this problem.

I think that this sounds reasonable but at this moment I have not got enough time because there are a lot of mods (in the modpack) and it'll take a lot of time to do it.

Kutilak commented 3 years ago

SevTech Ages v3.2.1 is still doing that.

YAPNie commented 3 years ago

Just an additions for SevTech Ages v3.1.2 hotfix 1. I put the Tower inside a glass Cage and Tower began teleporting rarely, much rarely than before but continue relatively friequently blinking (I suppose it tries teleporting but because of Cage it eventually teleports at the place where it stands before). It looks like it continue working after blinking. Very seldom it can teleport outside the Cage and it just a texture because I can walking through it. Of course at this moment Tower stops working.

It looks like I have to return to v3.0.8 because 3.1.2 hotfix 1 also have a strange (incorrect) behaviour with interaction Simple Storage Network and Storage Drawers.

My glass Cage looks like this: image

ExDomino commented 3 years ago
1. SevTech Ages v3.0.8 - NO issue.
2. SevTech Ages v3.1.2 hotfix 1 and v3.1.7 - issue presents.

Only test mods that have been added or updated in 3.1.2 from 3.0.8. Try to remove them one by one, when starting with the added mods and then with the updated mods.

YAPNie commented 3 years ago
1. SevTech Ages v3.0.8 - NO issue.
2. SevTech Ages v3.1.2 hotfix 1 and v3.1.7 - issue presents.

Only test mods that have been added or updated in 3.1.2 from 3.0.8. Try to remove them one by one, when starting with the added mods and then with the updated mods.

Yep, I caught the idea, but ... As far as I understand I should remove one mod, start Minecraft, load my world and check the issue precence. Repeat it for every mod. There are about 250 mods, Minecraft takes about 5 minutes for starting plus loading the world and testing. So, as I can see it will take tons of time because according to Murphy's law the "bad mod" will be the last mod I will check. I am not a programmer so I don't know whether it is possible to debug the code and find every mod that "touch or move" Tower during the game. At the same time I am not ready to waste a lot of time just for sorting out all the mods.

Also, it may be that this issue appears because of two or more mods.

ExDomino commented 3 years ago

There are not 250 mods that have been added or updated from the version 3.0.8 to 3.1.2 of your modpack. You said you did not have the problem in 3.0.8, then do not test mods that this version have.

YAPNie commented 3 years ago

Ops, sorry, it looks like I did not read your post carefully before. Action plan looks like: 1) find a way to repeat the issue in v3.1.2 hotfix 1 2) there are also some beta-versions between 3.0.8 (works well) and 3.1.2hotfix1 (fails), so try other "intermediate" versions. Maybe the issue arose before in beta-version vX.X.X. 3) compare using mods and their versions in 3.0.8 and vX.X.X. 4) For updated mods try to disable the mod or return previous version of the mod.

By the way, I tried to repeat the issue in a new superflat world (v3.1.2hotfix1) and could not repeat the issue. It's a pity. Maybe a hostile mob must be near or something else, so I will have to use my world where the issue repeats.

YAPNie commented 3 years ago

Just for history. I copied my world from v3.1.7 to v3.1.2 (Beta). Of course, during loading save from 3.1.7 in 3.1.2 it showed warnings, I ignored them. The issue repeated. Then I took save from v3.1.2 (beta) and loaded it in v3.1.1 (beta) - no issue. So, it looks like:

  1. SevTech Ages v3.0.8 - NO issue.
  2. SevTech Ages v3.1.1 (beta) - NO issue.
  3. SevTech Ages v3.1.2 (beta) - issue presents.
  4. SevTech Ages v3.1.2 hotfix 1 and v3.1.7 - issue presents.
YAPNie commented 3 years ago

Just for history again. :) I compared the mods lists (in WinMerge) and visually about half of them have updated versions and there are some new mods. Maybe I will try to find the "bad mod" but anyway it will take a lot of time. At least, I know the version when the issue appeared.

ExDomino commented 3 years ago

Ignore the updated mods for now, try to remove one by one the new mods added from the 3.1.1 beta to the 3.1.2 beta. Ignore the 3.0.8, the 3.1.2 hotfix and the 3.1.7. If the issue is still present in 3.1.2 beta after removing all the new mods added by this version, then only test the updated mods.

A best way to speed up your tests is to make a list of the new mods added and then removing half of them and test if the issue is still there or not. After, removing half of the other mods that you have not tested yet, and so on.

YAPNie commented 3 years ago

Shortly speaking it looks like the root cause is SimpleStorageNetwork. SevTech Ages v3.1.1 (beta): SimpleStorageNetwork-1.12.2-1.5.7.jar - enabled - no issue. SevTech Ages v3.1.2 (beta): SimpleStorageNetwork-1.12.2-1.7.6.jar - enabled - issue presents. SevTech Ages v3.1.2 (beta): SimpleStorageNetwork-1.12.2-1.7.6.jar - disabled - no issue. SevTech Ages v3.1.2 (beta): SimpleStorageNetwork-1.12.2-1.5.7.jar - enabled - no issue. SevTech Ages v3.1.7: SimpleStorageNetwork-1.12.2-1.7.11.jar - disabled - no issue.

I tried to reproduce the issue in superflat world in 3.1.7 - couldn't.

As I wrote before the behaviour of SimpleStorageNetwork changed. IMHO when I played v3.0.8 it worked predictably, but in v3.1.7 I noticed that behaviour become strange (it put an item in an empty chest even there already was a chest in the network with the same items).

YAPNie commented 3 years ago

@ExDomino - thanks to your support I eventually found the root cause (at least I hope so) and can play SevTech Ages again. I will just stop using SimpleStorageNetwork (with its strange behaviour in its new version it is useless anyway) and will hope that there will not arise another bug.

ExDomino commented 3 years ago

Are you able to test each version of SimpleStorageNetwork between 1.5.7 to 1.7.6 in order to see what version has begin to cause this problem? After that, the report should be done on their issue page. The possibility of downloading your map could help them to reproduce the issue in order to fix it.

YAPNie commented 3 years ago

R SimpleStorageNetwork-1.12.2-1.7.6.jar NotOk B SimpleStorageNetwork-1.12.2-1.7.5.jar
R SimpleStorageNetwork-1.12.2-1.7.4.jar
R SimpleStorageNetwork-1.12.2-1.7.3.jar
R SimpleStorageNetwork-1.12.2-1.7.2.jar NotOk B SimpleStorageNetwork-1.12.2-1.7.1.jar
A SimpleStorageNetwork-1.12.2-1.7.0.jar
B SimpleStorageNetwork-1.12.2-1.6.6.jar NotOK B SimpleStorageNetwork-1.12.2-1.6.5.jar
B SimpleStorageNetwork-1.12.2-1.6.4.jar
A SimpleStorageNetwork-1.12.2-1.6.3.jar
A SimpleStorageNetwork-1.12.2-1.6.2.jar
A SimpleStorageNetwork-1.12.2-1.6.1.jar
A SimpleStorageNetwork-1.12.2-1.6.0.jar NotOK R SimpleStorageNetwork-1.12.2-1.5.7.jar Ok

YAPNie commented 3 years ago

If the Tower disappears or Moved it can be "return back" by RMB on the place where it was before. It looks like the root cause is RequestTable or/and MasterModule. I tried with v1.12.2-1.6.0:

ExDomino commented 3 years ago

I should say to test until you find your first non ok update. So the problem started with their complete rewrite in 1.6.0. Can you create a modpack with only ImmersvePetroleum and SimpleStorageNetwork, and their dependencies, and reproduce the bug?

YAPNie commented 3 years ago

I have no ideas how to create a modpack. I did the following: 1) disabled almost all mods in SevTech Ages v3.1.2 (I will attach a screenshot). 2) loaded my world (~200MB in 7z) 3) The Tower disappeared 4) I went down (minus first floor) and deleted RequestTable and MasterBlock 5) Then I came back and "returned back" Tower by clicking RMB on the place it was before 6) Then Tower did not disappeared anymore. image