search

Fledge68 / WiiFlow_Lite

My mod of the Wii USB Loader WiiFlow
470 stars 58 forks source link

[Bug] Writing cheat textfiles that are only intended to be read #283

Closed eku closed 3 years ago

eku commented 3 years ago

According to the posting in gbatemp, WFL marks cheats as set by changing the original cheat file. The input file should never be approved for writing.

I suggest, analogous to usbloader_gx, to simply evaluate the GCT file to get the information.

The two loaders do not differ so much in the gct.cpp that one could not adopt it with little effort. Perhaps @wiidev would like to support with a PR.

Fledge68 commented 3 years ago

the gct file is made correctly and txt file is no longer rewritten. but i discovered that cheats seem to be broken. i tried super mario galaxy and cheats didn't work. the same cheats work on usb loader gx. seems something is broken somewhere.

eku commented 3 years ago

I'm glad you implemented a solution so quickly.

Do you have any idea how we can solve the problem of the cheats not working? I could in principle support via git bisect, but only the versions that are compatible with the current devKitPro. Is it known with which version it still works?

Fledge68 commented 3 years ago

so after working my way from v5.4.8 all the way to 5.5.0 beta 9. it turns out there is no problem with cheats working. the latest commit works just fine. i'm not sure why they didn't work before (maybe i had bad build or corrupt file). but everything's fine.

eku commented 3 years ago

May I ask if you also tested cheats on Virtual Console Games in NAND and EmuNAND?

Fledge68 commented 3 years ago

emunand yes. i tried adventure island and it worked. real nand i don't use.