search

Fledge68 / WiiFlow_Lite

My mod of the Wii USB Loader WiiFlow
459 stars 58 forks source link

Deleting a plug-in game does not delete covers. #311

Open eku opened 2 years ago

eku commented 2 years ago

Describe the bug The red cross in game menu deletes the game, but not any associated files.

To Reproduce Steps to reproduce the behavior:

  1. Select a NES game
  2. Click on red cross in game menu
  3. Confirm delete
  4. Check cover, cart_img, snapshot and cache folder

What version of WiiFlow Lite v5.5.3

On Wii or Wii U vWii Wii

Screenshots none

Additional context The menu action triggers CMenu::_wbfsOp(WO_REMOVE_GAME). This in turn calls RemoveCover(CF_Hdr->id) to delete the images. This function can only handle Gamecube and Wii games.

As a result, artifacts from emulator games remain until you delete them manually. This unnecessarily fills the SD card.

eku commented 2 years ago

@Fledge68 Do you want me to submit the changes as PR or do you do it yourself?

Fledge68 commented 1 year ago

i've already fixed this but do not want to delete cart images and snapshots. those are part of the database. or as an option ask to delete those if wanted but i would rather not

eku commented 1 year ago

do not want to delete cart images and snapshots

Are there really users who have installed the complete set of cartidges and snapshot images? I tend to think not.

No matter, a delete menu similar to USB Loade GX leaves it up to the user.