search

Fleker / CumulusTV

Android TV Live Channel Plugin with user-entered stream files
MIT License
185 stars 72 forks source link

m3u import, google drive crash latest beta #241

Closed ghost closed 7 years ago

ghost commented 7 years ago

using cumulus 1.7.2 beta and android tv 6.0.1 (Mibox) when trying to import m3u standard format :

EXTINF:-1 tvg-ID="" tvg-name="channel" tvg-logo="" group-title="group 1",channel

http://s.xxx.com:8000/live/xxx/xxx/1.ts

cumulus is crashing , while :

EXTINF:-1 ,channel

http://s.xxx.com:8000/live/xxx/xxx/1.ts

is working. maybe because some fields are empty ?

also google drive is not working anymore, it crash when you try to use it, i have tried to reset app datas already

i will try to send bugreports next time that i will use the app,

Fleker commented 7 years ago

Where are you importing from? Google drive? That currently isn't supported.

Should I make that more clear?

On Jan 24, 2017 10:13 AM, "i" notifications@github.com wrote:

when trying to import m3u standard format :

EXTINF:-1 tvg-ID="" tvg-name="channel" tvg-logo="" group-title="group

1",channel http://s1.xxx.com:8000/live/xxx/xxx/802.ts

cumulusc is crashing , while :

EXTINF:-1 , channel

http://s1.xxx.com:8000/live/xxx/xxx/802.ts

is working

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Fleker/CumulusTV/issues/241, or mute the thread https://github.com/notifications/unsubscribe-auth/ADI587fV9l2RI2fR0LYuzmMDNgo1nVeTks5rVhUFgaJpZM4LsYdg .

ghost commented 7 years ago

No, from internal. It's 2 different crashs.

Le 24 janv. 2017 5:20 PM, "Nick" notifications@github.com a écrit :

Where are you importing from? Google drive? That currently isn't supported.

Should I make that more clear?

On Jan 24, 2017 10:13 AM, "i" notifications@github.com wrote:

when trying to import m3u standard format :

EXTINF:-1 tvg-ID="" tvg-name="channel" tvg-logo="" group-title="group

1",channel http://s1.xxx.com:8000/live/xxx/xxx/802.ts

cumulusc is crashing , while :

EXTINF:-1 , channel

http://s1.xxx.com:8000/live/xxx/xxx/802.ts

is working

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Fleker/CumulusTV/issues/241, or mute the thread https://github.com/notifications/unsubscribe-auth/ ADI587fV9l2RI2fR0LYuzmMDNgo1nVeTks5rVhUFgaJpZM4LsYdg .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fleker/CumulusTV/issues/241#issuecomment-274852683, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxnw_oGTaZVgGcKG-Ewbn1g9Ivl4KWvks5rViTDgaJpZM4LsYdg .

Fleker commented 7 years ago

I'll add both to the parser tests to see where the problem lies.

On Jan 24, 2017 11:22 AM, "i" notifications@github.com wrote:

No, from internal. It's 2 different crashs.

Le 24 janv. 2017 5:20 PM, "Nick" notifications@github.com a écrit :

Where are you importing from? Google drive? That currently isn't supported.

Should I make that more clear?

On Jan 24, 2017 10:13 AM, "i" notifications@github.com wrote:

when trying to import m3u standard format :

EXTINF:-1 tvg-ID="" tvg-name="channel" tvg-logo="" group-title="group

1",channel http://s1.xxx.com:8000/live/xxx/xxx/802.ts

cumulusc is crashing , while :

EXTINF:-1 , channel

http://s1.xxx.com:8000/live/xxx/xxx/802.ts

is working

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Fleker/CumulusTV/issues/241, or mute the thread https://github.com/notifications/unsubscribe-auth/ ADI587fV9l2RI2fR0LYuzmMDNgo1nVeTks5rVhUFgaJpZM4LsYdg .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fleker/CumulusTV/issues/241#issuecomment-274852683, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxnw_oGTaZVgGcKG- Ewbn1g9Ivl4KWvks5rViTDgaJpZM4LsYdg .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Fleker/CumulusTV/issues/241#issuecomment-274853303, or mute the thread https://github.com/notifications/unsubscribe-auth/ADI58-CbtTat-VhN0M5xxK63zvGHoOUmks5rViU2gaJpZM4LsYdg .

Fleker commented 7 years ago

There were two issues with the playlists.

The first is that the first line doesn't contain #EXTM3U to identify it as the correct format. This is required based on how the parser works at the moment.

The second is that empty strings were causing the parser to be too greedy and shift too many characters, causing the whole parser to fail. This bug has been corrected and both streams are added to tests.