search

Flemmbrav / Pak192.Comic

Pakset and Theme for Simutrans
https://forum.simutrans.com/index.php/board,120.0.html
Other
25 stars 20 forks source link

Compiler Error GitHub Action #18

Open Flemmbrav opened 4 years ago

Flemmbrav commented 4 years ago

Multiple of these.

"Warning: Failed to get one or more hashes on pakset/buildings/city/com_3northsea.dat"

We might either not try to generate hashes no more, or to fix the hashes.

vzrenggamani commented 4 years ago

It refering to the this commit i think https://github.com/Flemmbrav/Pak192.Comic/commit/d2eed7a912ec7122dfb608abe1b6a73aaf917e0f

Leartin commented 4 years ago

The hashes are in a csv-file in the pakset folder, and are obviously only working if 'compiled' was created before and not changed. The github action leaves no 'compiled'-folder behind, so there are no hashes from previous runs. Personally, I never left the 'compiled'-folder in place either, so the hashes never worked for me.

However, I'd see them as an option - you can build clean from scratch or just update your existing pak. For the automatic release, building from scratch would always be the way to go anyway.

The script could check for the csv file in the beginning and give a warning once if it's missing, rather than seperately for each dat. I'd consider that a cosmetic change though.

Flemmbrav commented 4 years ago

Do they work for you locally?