Flemmli97 / Flan

Fabric Landclaiming Mod
80 stars 34 forks source link

Wandering Trader trade permissions are controlled by ANIMALINTERACT instead of TRADE as expected #281

Closed techheadfred-git closed 4 months ago

techheadfred-git commented 5 months ago

Modloader

Fabric

Minecraft version

1.20.1

Modloader version

Fabric Loader 0.15.6, Fabric API version 0.91.0+1.20.1

Mod version

1.20.1-1.9.1-fabric

Description

Wandering Trader trade permissions are controlled by ANIMALINTERACT instead of TRADING as expected. This is not ideal, as setting this flag allows for mounts and animals to be killed or stolen.

Steps to reproduce

  1. Set the TRADING flag to true in a claim.
  2. Spawn a Wandering Trader, or wait for one to spawn
  3. Have someone not trusted in the claim attempt to trade with the Wandering Trader. They will be told they can't
  4. Confirm that the same player can trade with villagers in the same claim.
  5. Change the ANIMALINTERACT flag to true
  6. Have someone not trusted in the claim attempt to trade with the Wandering Trader. They will be able to.

Mods that might affect the issue

Not aware of any mods known to be incompatible.

Full mod list:

Architectury Banhammer Cloth-config Cupboard Farsight FerriteCore Flan GriefLogger Krypton Lithium LuckPerms LuckPerms Fabric Placeholder API Hook No Chat Reports RenameIt Replay Voice Chat Servux ShulkerPlus SimpleBackup Simple Voice Chat Sodium Starlight Status Styled Chat Styled Nicknames Styled Player List Supermatrijn642configlib Syncmatica

Logs

No relevant entries found in logs. Happy to provide them if you can advise location of Flan logs