LGTM Achievement or addition to "Vital Contributor"

Flet / rejected-github-profile-achievements

😵 GitHub achievements that did not make the cut.

MIT License

1.54k stars 19 forks source link

Open doyler opened 1 year ago

doyler commented 1 year ago

There is currently no achievement for 100 issue comments stating "LGTM".

This should either have its own achievement or be added as an alternative path for obtaining the "Vital Contributor" achievement.

Flet commented 1 year ago

Ohh, I like this idea.

Flet commented 1 year ago

I think this should be combined with #11 and maybe as

"The Auditor - Comment LGTM on 100 pull requests within 1 minute of opening."

burdges commented 1 year ago

1 minute is extremely fast, but also 100 is not so many. I'd say:

Vital Contributor - Participated in over 100 issues or PRs with just a "+1" or a thumbs up emoji, or only a "LGTM".

Around this, speed reader feels way too hard to achieve:

Speed Reader - Review and approve a pull request that contains over 10,000 lines of code in under 5 minutes.

I think The Auditor is a great name, but it should be differentiated from Speed Reader somehow.