Mohit/currency manager - Githubissues

Flex-NFT-Marketplace / Flex-Marketplace-Contract

12 stars 40 forks source link

Mohit/currency manager #20

Closed Mohiiit closed 10 months ago

Mohiiit commented 10 months ago

updated the code of the currency_manager module which #5
added tests for the module as well
one key finding is that: we can't have function named onwer and transfer_ownership because they will clash with the ownable component we are using

ametel01 commented 10 months ago

@Mohiiit remove all the test we will open separate issues for those

ametel01 commented 10 months ago

@and1vo can you approve the workflows for this PR?

possc commented 10 months ago

@and1vo can you approve the workflows for this PR?

Approved!

possc commented 10 months ago

@and1vo can you approve the workflows for this PR?

I think the workflow fails because #19 hasn't been merged yet; we should resolve #19 first.

ametel01 commented 10 months ago

@and1vo can you approve the workflows for this PR?

I think the workflow fails because #19 hasn't been merged yet; we should resolve #19 first.

it doesn't look like any workflow has been run for this PR, there are still merge conflicts to be solved @Mohiiit

Mohiiit commented 10 months ago

@and1vo can you approve the workflows for this PR?

I think the workflow fails because #19 hasn't been merged yet; we should resolve #19 first.

it doesn't look like any workflow has been run for this PR, there are still merge conflicts to be solved @Mohiiit

yes, I will solve the merge conflicts, I thought once the upgradable doubt is resolved, I will solve the merge conflicts

ametel01 commented 10 months ago

2 more thing:

add #[flat] decorator to component event.
add the ownable method to the ICurrencyManage interface only: fn owner() and fn transfer_ownership()

After that it LGTM!

Mohiiit commented 10 months ago

I will create another pull request soon this week.