Problem with states which have the same type

FlexBE / flexbe_app

The classic user interface (editor + runtime control) for the FlexBE behavior engine. See the flexbe_webui for latest

BSD 3-Clause "New" or "Revised" License

48 stars 49 forks source link

Problem with states which have the same type #15

Closed GabrielHuettenberger closed 5 years ago

GabrielHuettenberger commented 6 years ago

When having two state types with identical names in different state packages, the App only shows one of the two types twice when using the Add State feature. Which type is shown twice seems to change randomly on App restart. state_type1 state_types2

pschillinger commented 6 years ago

Thanks for reporting, I will look into it.

Independent of this, I would suggest to give rather specific names to states and make sure that states are indeed different in the sense that they are more than just two different hardcoded parametrizations of the same functionality. But of course, the issue you reported needs to be fixed.

pschillinger commented 5 years ago

This problem should be fixed now by the above referenced commit.

In short:

Duplicate state class names are now correctly handled within the app.
For generated code, duplicate state classes are imported with according aliases. This enables to correctly load the respective state class when loading a behavior in the app.
There is a new entry in the settings to do the above explicitly for all state classes even if unique.