FlexSearch / FlexLucene

IKVM Build scripts
Apache License 2.0
16 stars 5 forks source link

Integrate japanese analyzer #11

Open Matthias-Acolada opened 7 years ago

Matthias-Acolada commented 7 years ago

Hi there,

this is rather a feature request than an issue: Could you integrate the japanese analyzer into FlexLucene? This analyzer is not part of 'lucene-analyzers-common-x.x.x.jar' but has it's own jar: lucene-analyzers-kuromoji-x.x.x.jar.zip

Maybe this is possible for you?

Thanks and best regards, Matthias

seemantr commented 7 years ago

Hi Matthias,

Thanks for getting in touch. I can't promise but the request seems simple to implement. I will have a look at it during the weekend when I will create a new release for Lucene 6.3, hopefully, should be in by mid of next week.

Cheers, Seemant

seemantr commented 7 years ago

Hi Matthias,

I have just released a new version of FlexLucene which has the Japanese analyzer. The new release is available on NuGet. Can you please have a look at the library and report back any issues that you may encounter?

Cheers, Seemant

Matthias-Acolada commented 7 years ago

Wow, that was quick! Thanks a lot, i will try it today and give a feedback!

cheers, Matthias

Matthias-Acolada commented 7 years ago

Hi Seemant,

unfortunatly I does not work - I get this exception when I call writer.AddDocument(ptr_document);:

Maybe the integrated dictionary "targetmap.dat" is not included or cannot be accessed?

image

cheers, Matthias

seemantr commented 7 years ago

Hi Matthias,

Yes, you are right the compiled DLL is missing the dat resource. We usually pick up all the text resources. I have updated the generation code to pick up the dat resources as well. This has increased the DLL size by 4 MB.

Anyhow I have just committed the updated DLL in the repository under the artifact folder. Can you please give it a try and let me know if it works now? Once I get a confirmation from you I will create a new NuGet package with the fix.

Cheers, Seemant

Matthias-Acolada commented 7 years ago

Hi Seemant,

it works! Thanks again for this very fast integration and bugfixing,

cheers, Matthias