FlexTradeUKLtd / jfixture-scala

Customisations for JFixture to make it more useful when writing Scala
3 stars 4 forks source link

Issue #14 Build JFixture-Scala against both Scala 2.11 and 2.12 #15

Closed Rocketeer007 closed 5 years ago

Rocketeer007 commented 5 years ago

Add build.sbt for cross compiling using sbt.

Update README.md to show syntax for sbt and for maven using latest version

Rocketeer007 commented 5 years ago

I'm not 100% certain about three points here:

  1. Should I remove the Maven pom.xml file as part of switching to SBT? 1a. Will doing that break the Travis build? It seems to start with mvn install, then run build.sh...
  2. Have I broken the publishing logic which gets the security details from the Travis environment?
  3. Is 1.0.1-SNAPSHOT the right version for this?
phutchin commented 5 years ago

Actually just saw your questions:

  1. Yes we should remove the pom.
  2. It doesn't look broken, but we can go through some tests to make sure it works after this, and if need be push another fix.
  3. Master should probably be on 1.1.0-SNAPSHOT (looks like whoever released last didn't bump it), so then this would be in a 1.1.0 release