Breaking change in email notificationplugin

[danez]

Expected behaviour:

Send on mail by task

Actual behaviour:

Send multiple mails by task (sends one per entry)

Steps to reproduce:

• Step 1: flexget execute with following config

Config:

tasks:
  some:
    rss: ...
    email:
      to: x@mail.com
      from: y@mail.com

Log:

2016-12-19 11:57 VERBOSE  notify        some             Successfully sent a notification to `email`
2016-12-19 11:57 VERBOSE  notify        some             Successfully sent a notification to `email`
2016-12-19 11:57 VERBOSE  notify        some             Successfully sent a notification to `email`
2016-12-19 11:57 VERBOSE  notify        some             Successfully sent a notification to `email`
2016-12-19 11:57 VERBOSE  notify        some             Successfully sent a notification to `email`
2016-12-19 11:57 VERBOSE  notify        some             Successfully sent a notification to `email`
2016-12-19 11:58 VERBOSE  notify        some             Successfully sent a notification to `email`
2016-12-19 11:58 VERBOSE  notify        some             Successfully sent a notification to `email`

Additional information:

• Flexget Version: 2.8.7
• Python Version: 3.4.5
• Installation method: virtualenv + pip
• OS and version: gentoo linux latest

I updated recently and flexget started to send mails per entry instead of per task. I see that I can fix it myself with https://flexget.com/Plugins/Notifiers/notify_task, though I think this was a breaking change and probably should default to per task.

[liiight]

This is exactly what UpgradeActions and the forum is for.

[cvium]

I think this is actually a bug with the backwards compatibility.