convert_magnet if failed/timed out, downloaded to root folder

zilexa commented 5 years ago

Expected behaviour:

If convert_magnet fails or if there is a time out, it should simply stop working on this item and move on to the next.

Actual behaviour:

Although the log shows flexget is moving on, I see my flexget root folder filling up with entire downloads of the timed out magnets! These are the ones that failed or timed out and therefore are not being accepted by Flexget to download. However they do appear in the root folder, eventually clogging the drive Flexget is installed on.

Steps to reproduce:

Step 1: let flexget search for magnets and use convert_magnet. Set a short time out window. (note I actually use 120 seconds!)

Additional information:

FlexGet version: 2.11.21 (newer versions don't work)
Python version: 3.5
Installation method: pip on Debian, virtual_env
Using daemon (yes/no): yes and no, tested without daemon
OS and version: Debian Stretch

cvium commented 5 years ago

RTF(riendly)M

By default, the plugin will not fail entries if the conversion is unsuccessful, but setting force: yes will do so.

https://flexget.com/Plugins/convert_magnet

zilexa commented 5 years ago

I have that in my config everywhere: https://github.com/zilexa/Flexget-the-lazy-couch-experience/blob/master/config.yml

    magnets: yes
    convert_magnet:
      timeout: 180 seconds
      force: yes

now allowing 180 seconds seems to solve it for now.

cvium commented 5 years ago

Some debug logs would be helpful. Based on the code, it should fail any entry that times out.

Flexget / Flexget