Closed effemmeffe closed 2 years ago
I'm not using the letterbox plugin but my 2 cents, guessing from code and crash log: The issue is that https://letterboxd.com/film/daniel-sloss-live-shows/ doesn't have data-tmdb-id
attribute value filled in <body>
tag and letterboxd
plugin doesn't count with such case.
Fast workaround to get at least rest of it running is to change plugins/input/letterboxd.py
arround line 81
from:
def parse_film(self, film, config):
url = base_url + film.get(config['f_slug'])
soup = get_soup(requests.get(url).content)
result = self.tmdb_lookup(soup.find(attrs={'data-tmdb-id': True}).get('data-tmdb-id'))
to something like:
def parse_film(self, film, config):
url = base_url + film.get(config['f_slug'])
soup = get_soup(requests.get(url).content)
tmdb_id = soup.find(attrs={'data-tmdb-id': True}).get('data-tmdb-id')
if tmdb_id is None:
return []
result = self.tmdb_lookup(tmdb_id)
This workaround should simply skip the entries with data-tmdb-id
attribute missing. It would be better to fix the plugin to try to search for tmdb_id
later in text, as it is present on the page. I'm not fluent with Soap but it shouldn't be hard to fix.
This issue is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 30 days.
Someone checked this?
Can you paste the log in the actual ticket rather than pastebin? It needs an account to open up, and if the paste ever expires this ticket will lose all context.
Can you paste the log in the actual ticket rather than pastebin? It needs an account to open up, and if the paste ever expires this ticket will lose all context.
Done
@effemmeffe Thanks! Looks like this crash was fixed in https://github.com/Flexget/Flexget/commit/9da2b1ed1dcff7b4f22023067f51b7c7cb40b1fe
Not sure why that show doesn't have a tmdb id on letterboxd though.
Expected behaviour:
Get movies from letterboxd list and add them to trakt list
Actual behaviour:
Get a crash report
Steps to reproduce:
Run:
flexget execute --tasks *comedy*
Config:
https://github.com/effemmeffe/flexget/blob/master/config.yml
Log:
(click to expand)
``` 2020-12-24 11:29:11 VERBOSE api_tmdb letterboxd-comedy Searching from TMDbAdditional information: