search

FlexibleEngineCloud / terraform-provider-flexibleengine

Terraform flexibleengine provider
https://www.terraform.io/docs/providers/flexibleengine/
Mozilla Public License 2.0
30 stars 53 forks source link

feat(VPC): add secgroup_rule_v2 data source #1068

Open alexissellier opened 9 months ago

alexissellier commented 9 months ago

What this PR does / why we need it: Add data source for secgroup_rule_v2

Which issue this PR fixes: (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged) fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

Acceptance Steps Performed


make testacc TEST='./flexibleengine/' TESTARGS='-run TestAccFlexibleEngineNetworkingSecGroupRuleV2DataSource_basic'
=== RUN   TestAccFlexibleEngineNetworkingSecGroupRuleV2DataSource_basic
--- PASS: TestAccFlexibleEngineNetworkingSecGroupRuleV2DataSource_basic (38.66s)
PASS
ok      github.com/FlexibleEngineCloud/terraform-provider-flexibleengine/flexibleengine 38.685s
ShiChangkuo commented 9 months ago

@alexissellier Thank you for the pull request.

it's very appreciate if we add a new data source with plural format, such as flexibleengine_compute_instances, which is more convenient for users.

alexissellier commented 9 months ago

Hi @ShiChangkuo ,

Noted, I will add a flexibleengine_networking_secgroup_rules data source

chengxiangdong commented 9 months ago

/retitle feat(VPC): add secgroup_rule_v2 data source