Fixed issue #239: Don't ignore explicitly mentioned folders, even tho…

FlineDev / BartyCrouch

Localization/I18n: Incrementally update/translate your Strings files from .swift, .h, .m(m), .storyboard or .xib files.

MIT License

1.37k stars 121 forks source link

Fixed issue #239: Don't ignore explicitly mentioned folders, even tho… #240

Closed tladesignz closed 2 years ago

tladesignz commented 2 years ago

…ugh they might contain otherwise ignored folders as their parent folders.

Fixes #239

Proposed Changes

Cuts off user-given base folders, only checks automatically scanned folders therein, if they contain an ignored item.

As discussed on the issue!

FlineDevPublic commented 2 years ago

@tladesignz Thank you very much for this PR. I just actually "merged" with some changes in 4d865ca589fb15ad977d218c116bc81f82bddd64 & fd17d054fe248ce5588a15c210bd8863bda390b4 to fix some code conventions (skipped the creating a PR on your fork and just pushed right away). Closing this. 🎉

This comment was written during my regular Open Source live stream on Twitch. Follow me there to support my work!

tladesignz commented 2 years ago

Yay! Thank you!

FlineDevPublic commented 2 years ago

@tladesignz This was just released in 4.9.0. 🎉

This comment was written during my regular Open Source live stream on Twitch. Follow me there to support my work!