search

FlineDev / CSVImporter

Import CSV files line by line with ease
MIT License
148 stars 31 forks source link

Hi I can't use importer library #10

Closed ttoggaiman closed 7 years ago

ttoggaiman commented 8 years ago

my env is xcode 8 , swift 2.3(legacy swift check)

I have make sample project and i add importer library with cocoapods but it didn't work

1

2

Jeehut commented 8 years ago

Thank you for reaching out. What we need to do is to update the library to Swift 2.3 and 3 and keep branches for both (I suggest a support/swift2.3 branch for Swift 2.3 and a new version for Swift 3).

Unfortunately I won't have time until next week to do this, if you need it right now feel free to fork this project, migrate the Code to Swift 2.3 (Xcode will help you out!) and try using your own fork.

Jeehut commented 8 years ago

@ttoggaiman I just added support for Swift 3 and released the new version 1.3.0 with support for it.

I also just started migration to Swift 2.3 but recognised that the dependency FileKit doesn't have a Swift 2.3 compatible version available, so I couldn't complete the Swift 2.3 support (and won't be able to) until FileKit gets a 2.3 compatible version. Feel free to open an issue on the FileKit project (or upgrade to Swift 3).

Jeehut commented 8 years ago

Ah, just realised that you can not install CSVImporter via CocoaPods since I can't specify the Swift 3 compatible version of FileKit as a dependency. I'll have to wait until they release a compatible version. There's one in the make as you can see here.

In the meantime you can use Carthage (which I would recommend anyway) to install CSVImporter with Swift 3 support.

phoney commented 7 years ago

They seem to have merged that swift-3 branch. CocoaPods isn't working for me though.

phoney commented 7 years ago

I think the podspec file is wrong. It says

s.dependency "Dschee-FileKit", "~> 4.0"

and should say

s.dependency "FileKit", "~> 4.0"

phoney commented 7 years ago

Thanks for fixing the podspec. I think you still need to pod trunk push. I can't access version 1.3 from a podfile like this pod 'CSVImporter', '~>1.3' although this does get me version 1.3 and its two dependencies correctly pod 'CSVImporter', :git => 'https://github.com/Flinesoft/CSVImporter.git'

Jeehut commented 7 years ago

Yeah, you're right of course. Was having problems at first and forgot. Just released v1.3 via CocoaPods now, hope the problem is fixed! 🎉

(If not, just reopen the issue.)