search

FlineDev / RemafoX

Report issues, request features or ask for help for the ReMafoX app here.
30 stars 1 forks source link

[Feat] Should give feedback when a language code fails #83

Open ConfusedVorlon opened 1 year ago

ConfusedVorlon commented 1 year ago

Steps to Reproduce:

I set up some languages using folder codes copied from another app. Amongst others, I used pt.lproj

Expected Behavior:

strings should translate - or give a useful message

Current Behavior:

translations fail silently (using Microsoft translate)

Comment

I remembered an old bug where RemaFox crashed on the pt folder, looked at that, and realised I needed pt-PT That's fine - but it would have been super helpful for RemaFox to tell me that it couldn't handle a particular lproj folder, and perhaps link me to a list of supported folder codes

(fwiw - iOS is perfectly happy with pt)

I hit similar issues with a few other languages, I didn't note them down :(

Environment

Show environment details - App Version: 1.4.1 (Build 63) - System Version: 13.2.1 (Build 22D68) - System CPU: Apple M1 Ultra - Tier: Pro
Jeehut commented 1 year ago

@ConfusedVorlon Thank you for reporting this. It totally makes sense to provide more detailed information when something fails so users can understand the problem better. It's true that not all languages you can potentially choose in Xcode are supported. And for some codes like pt there is some ambiguity involved and translation services support different versions (pt-PT and pt-BR) where I wouldn't know what to do with a language pt (should I choose Portugal, the originating country, or Brazil, the country with most speakers?), so I opted for the more clear ones. But especially for those cases that will commonly occurr, I should provide a better handling so users don't get confused. Will tackle soon!

Jeehut commented 1 year ago

@ConfusedVorlon I just checked this and I couldn't find any crash here, it seems the crash has already been fixed with a previous update. The only problem here seems to be that the translation skips languages it doesn't know about, which I don't really consider a bug. But I totally agree that there should be some kind of feedback for users about non-supported languages and maybe even a tip to use a different code if the language is basically supported, but under a different code.

I think I will solve this together with https://github.com/FlineDev/RemafoX/issues/71 sometime later.