Flink / dokku-psql-single-container

Plugin for dokku that provides a Postgresql server in a single container
MIT License
51 stars 9 forks source link

Add helpful error on "dokku psql:restore x y.dump" without "<" #16

Closed henrik closed 9 years ago

henrik commented 9 years ago

I misread the docs and forgot the "<". That appears to just do nothing, silently waiting for input on the command-line.

Maybe the plugin could notice that situation and provide a helpful message?

Flink commented 9 years ago

Yes this is directly pg_restore waiting for input. But I think you’re right and we could check for data on stdin. If there isn’t any, we could output a message explaining the problem.

henrik commented 9 years ago

Yeah, that sounds great. Maybe I'm the only one to ever make this mistake but I shouldn't think so :)

Sent from my iPhone

On 24 Aug 2015, at 17:37, Loïc Guitaut notifications@github.com wrote:

Yes this is directly pg_restore waiting for input. But I think you’re right and we could check for data on stdin. If there isn’t any, we could output a message explaining the problem.

— Reply to this email directly or view it on GitHub.

Flink commented 9 years ago

Merged in latest master :wink:

henrik commented 9 years ago

Oh, brilliant. Thank you!

Sent from my iPhone

On 24 Aug 2015, at 23:06, Loïc Guitaut notifications@github.com wrote:

Merged in latest master

— Reply to this email directly or view it on GitHub.