search

Flink / dokku-psql-single-container

Plugin for dokku that provides a Postgresql server in a single container
MIT License
51 stars 9 forks source link

dump command waits for enter #6

Closed sfcgeorge closed 9 years ago

sfcgeorge commented 9 years ago

I tried using the dump command but it wouldn't return me to a prompt, I had to hit enter first. This makes it hard to use in scripts.

Removing the -i flag from the docker exec command seems to fix this and then it works as expected.

Could you remover the -i flag please, or is there a reason for it?

https://github.com/Flink/dokku-psql-single-container/blob/master/commands#L89

Flink commented 9 years ago

I don’t have any problem with it, using psql:dump in a backup script for some time now. But you’re right, in a terminal it waits for an input from user. I just did some tests and I don’t find any reason why there is this flag indeed. I’ll make a patch ;)

Flink commented 9 years ago

Fixed in latest master :)

sfcgeorge commented 9 years ago

Yay thank you, that was fast :) It's a nice plugin.

Flink commented 9 years ago

Thanks!