search

Flipboard / react-canvas

High performance <canvas> rendering for React components
BSD 3-Clause "New" or "Revised" License
13.18k stars 919 forks source link

Add id, or className to <Surface> #136

Closed CharlieGreenman closed 8 years ago

CharlieGreenman commented 8 years ago

I was wondering if architecturally there is a reason why react-canvas does not support putting an id tag or classNames on a tag? I would be more than willing to work on it. Thank you :)

CharlieGreenman commented 8 years ago

I have created a pull request for this "issue". If you think it is a bad idea, by all means I am more open to other suggestions. Thank you :)

https://github.com/Flipboard/react-canvas/pull/137

Nolski commented 8 years ago

@tuxracer I forgot to mention in the PR but this was resolved in #151

tuxracer commented 8 years ago

awesome thanks @Nolski!